57249[TASK] Use PHP_SAPI, PHP_VERSION and M_PI constant instead of functons calls
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Stefan Neufeind +1
- Oliver Klee +1
- Jörg Bösche +1
- Rudy Gnodde +1
-
Verified V +2
- Frank Nägler +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/install/index.php+1 −1
- typo3/sysext/backend/Resources/Private/Php/backend.php+1 −1
- typo3/sysext/core/Classes/Console/CommandApplication.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/NumberViewHelperTest.php+2 −2
- typo3/sysext/frontend/Resources/Private/Php/frontend.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php2+1 −1
- typo3/sysext/install/Resources/Private/Php/install.php+1 −1
Review log 1113
-
Wouter Wolters uploaded patch set 1 06/17/18, 15:02
-
TYPO3com voted on patch set 1 V +1 06/17/18, 15:10 Completed build in 08m 00s on Sun, 17 Jun, 05:10 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24526
-
Susi Moog commented on patch set 1 06/17/18, 15:20
-
Wouter Wolters uploaded patch set 2 07/04/18, 17:42
-
TYPO3com voted on patch set 2 V +1 07/04/18, 17:50 Completed build in 08m 03s on Wed, 4 Jul, 07:50 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25083
-
Oliver Klee commented on patch set 2 07/05/18, 06:52
Check.php:254I think this line can then be simplified as well. -
Wouter Wolters commented on patch set 2 07/05/18, 06:56
@oliklee these changes are automatically generated by the PHP extended plugin. If you have further improvements please push them. I tend to keep the changes as close as possible to the output of the plugin. If I need to rebase these patches I redo them with the plugin and doing more changes than the plugin is doing is not so handy. -
Oliver Klee commented on patch set 2 CR +1 07/05/18, 15:16
Check.php:254ReplyOh, I've misread the code. As the version number will be used in the flash message, we cannot convert this to PHP_VERSION_ID. -
Rudy Gnodde voted on patch set 2 CR +1 07/06/18, 11:15
-
Jörg Bösche voted on patch set 2 CR +1 07/18/18, 06:54
-
Stefan Neufeind commented on patch set 2 V +1 CR +1 07/18/18, 08:41
Codewise fine. Is there a recommendation from the PHP-community to use this way for comparison? Speedwise I don't expect it will make a difference for us. -
Frank Nägler voted on patch set 2 V +2 CR +2 07/18/18, 17:12
-
Frank Nägler merged patch set 3 07/18/18, 17:14
SystemInformationToolbarItem.php:345