Review main Merged

57249[TASK] Use PHP_SAPI, PHP_VERSION and M_PI constant instead of functons calls

Wouter Wolters CR +2 V +2 Easy +11 −11 updated 07/18/18, 17:14

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Jörg Bösche +1
    • Rudy Gnodde +1
  • Verified V +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1113

  1. Wouter Wolters uploaded patch set 1 06/17/18, 15:02

  2. TYPO3com voted on patch set 1 V +1 06/17/18, 15:10 Completed build in 08m 00s on Sun, 17 Jun, 05:10 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24526

  3. Susi Moog commented on patch set 1 06/17/18, 15:20

    SystemInformationToolbarItem.php:345

    would PHP_OS_FAMILY make more sense in master?
  4. Wouter Wolters uploaded patch set 2 07/04/18, 17:42

  5. TYPO3com voted on patch set 2 V +1 07/04/18, 17:50 Completed build in 08m 03s on Wed, 4 Jul, 07:50 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25083

  6. Oliver Klee commented on patch set 2 07/05/18, 06:52

    Check.php:254

    I think this line can then be simplified as well.
  7. Wouter Wolters commented on patch set 2 07/05/18, 06:56

    @oliklee these changes are automatically generated by the PHP extended plugin. If you have further improvements please push them. I tend to keep the changes as close as possible to the output of the plugin. If I need to rebase these patches I redo them with the plugin and doing more changes than the plugin is doing is not so handy.
  8. Oliver Klee commented on patch set 2 CR +1 07/05/18, 15:16

    Check.php:254 Reply

    Oh, I've misread the code. As the version number will be used in the flash message, we cannot convert this to PHP_VERSION_ID.
  9. Rudy Gnodde voted on patch set 2 CR +1 07/06/18, 11:15

  10. Jörg Bösche voted on patch set 2 CR +1 07/18/18, 06:54

  11. Stefan Neufeind commented on patch set 2 V +1 CR +1 07/18/18, 08:41

    Codewise fine. Is there a recommendation from the PHP-community to use this way for comparison? Speedwise I don't expect it will make a difference for us.
  12. Frank Nägler voted on patch set 2 V +2 CR +2 07/18/18, 17:12

  13. Frank Nägler merged patch set 3 07/18/18, 17:14