Review main Abandoned

57251[TASK] Replace strlen calls than can have $... (=/!)== ''' construction

Wouter Wolters CR 0 V 0 Easy +25 −25 updated 09/20/18, 18:04

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 15

Review log 69

  1. Wouter Wolters uploaded patch set 1 06/17/18, 17:21

  2. TYPO3com voted on patch set 1 V -1 06/17/18, 17:29 Completed build in 08m 22s on Sun, 17 Jun, 07:29 PM Test Summary: 18 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24529

  3. Wouter Wolters uploaded patch set 2 06/17/18, 17:53

  4. TYPO3com voted on patch set 2 V -1 06/17/18, 18:01 Completed build in 08m 20s on Sun, 17 Jun, 08:01 PM Test Summary: 18 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24531

  5. Oliver Klee commented on patch set 2 06/17/18, 18:33

    GeneralUtilityTest.php:1501

    The expected value should be the first argument, not the second argument.
  6. Wouter Wolters uploaded patch set 3 07/04/18, 17:46

  7. TYPO3com voted on patch set 3 V -1 07/04/18, 17:54 Completed build in 08m 13s on Wed, 4 Jul, 07:54 PM Test Summary: 9 of 33128 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25084

  8. Andreas Kienast commented on patch set 3 07/04/18, 19:31

    IIRC we had that multiple times already and always ran into a regression, mostly because `strlen(null) === 0` behaves differently than `null === ''`, so I think we should switch to `empty()` at some places.

    TranslationConfigurationProvider.php:232 Unresolved

    I think a !empty() is better here
  9. Wouter Wolters abandoned the change 09/20/18, 18:04