57251[TASK] Replace strlen calls than can have $... (=/!)== ''' construction
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 15
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php1+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/StringUtility.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php1+1 −1
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+1 −1
- typo3/sysext/impexp/Classes/Task/ImportExportTask.php+1 −1
- typo3/sysext/impexp/Classes/Export.php+1 −1
- typo3/sysext/impexp/Classes/Import.php+5 −5
- typo3/sysext/impexp/Classes/ImportExport.php+5 −5
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+1 −1
Review log 69
-
Wouter Wolters uploaded patch set 1 06/17/18, 17:21
-
TYPO3com voted on patch set 1 V -1 06/17/18, 17:29 Completed build in 08m 22s on Sun, 17 Jun, 07:29 PM Test Summary: 18 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24529
-
Wouter Wolters uploaded patch set 2 06/17/18, 17:53
-
TYPO3com voted on patch set 2 V -1 06/17/18, 18:01 Completed build in 08m 20s on Sun, 17 Jun, 08:01 PM Test Summary: 18 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24531
-
Oliver Klee commented on patch set 2 06/17/18, 18:33
-
Wouter Wolters uploaded patch set 3 07/04/18, 17:46
-
TYPO3com voted on patch set 3 V -1 07/04/18, 17:54 Completed build in 08m 13s on Wed, 4 Jul, 07:54 PM Test Summary: 9 of 33128 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25084
-
Andreas Kienast commented on patch set 3 07/04/18, 19:31
IIRC we had that multiple times already and always ran into a regression, mostly because `strlen(null) === 0` behaves differently than `null === ''`, so I think we should switch to `empty()` at some places.TranslationConfigurationProvider.php:232UnresolvedI think a !empty() is better here -
Wouter Wolters abandoned the change 09/20/18, 18:04
GeneralUtilityTest.php:1501