Review main Merged

57252[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 06/18/18, 04:33

Commit message

while (strlen($this->primary) < 4 || strlen($this->secondary < 4)) {

should be

while (strlen($this->primary) < 4 || strlen($this->secondary) < 4) {

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Wouter Wolters uploaded patch set 1 06/17/18, 17:24

  2. TYPO3com voted on patch set 1 V +1 06/17/18, 17:32 Completed build in 08m 13s on Sun, 17 Jun, 07:32 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24530

  3. Georg Ringer voted on patch set 1 V +1 CR +1 06/17/18, 18:20

  4. Oliver Klee voted on patch set 1 CR +1 06/17/18, 18:32

  5. Benni Mack voted on patch set 1 V +2 CR +2 06/18/18, 04:33

  6. Benni Mack merged patch set 2 06/18/18, 04:33

  7. Benni Mack commented on patch set 2 06/18/18, 04:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d3fa85965503741d2f75773dda0d3831b625ff14