Review main Merged

57262[BUGFIX] Allow redirect from typo3/install again

Benni Mack CR +2 V +2 Easy +3 −1 updated 06/20/18, 08:08

Commit message

Due to refactorings of constants, Environment:isCli()
needs to be initialized now. This breaks the
existing redirect from typo3/install/ to
typo3/install.php, due to non-initialized Environment
API.

In this case, the environment is initialized.

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Benni Mack uploaded patch set 1 06/18/18, 16:18

  2. TYPO3com voted on patch set 1 V +1 06/18/18, 16:26 Completed build in 07m 52s on Mon, 18 Jun, 06:26 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24549

  3. Georg Ringer commented on patch set 1 V -1 06/18/18, 16:41

    doesn'T work for me. still same issue
  4. Georg Ringer voted on patch set 1 V +1 CR +1 06/18/18, 16:43

  5. Wouter Wolters voted on patch set 1 CR +1 06/18/18, 17:26

  6. Mathias Brodala commented on patch set 1 06/19/18, 07:13

    index.php:23

    Maybe stupid but since we perform a redirect afterwards anyways, do we need any of this at all?
  7. Benni Mack commented on patch set 1 06/19/18, 10:27

    index.php:23 Reply

    if we don't do it, it does not work :) we could simply do plain PHP here, of course.
  8. Mathias Brodala commented on patch set 1 06/19/18, 10:31

    index.php:23 Reply

    I just had a closer look and you are right, there is a streak of dependencies on internals within the redirect() method via GeneralUtility. Since this file is deprecated anyways, there's not much value putting much more work here. So please forget what I said. ;-)
  9. Markus Klein voted on patch set 1 V +2 CR +2 06/20/18, 08:08

  10. Markus Klein merged patch set 2 06/20/18, 08:08