57262[BUGFIX] Allow redirect from typo3/install again
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Benni Mack uploaded patch set 1 06/18/18, 16:18
-
TYPO3com voted on patch set 1 V +1 06/18/18, 16:26 Completed build in 07m 52s on Mon, 18 Jun, 06:26 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24549
-
Georg Ringer commented on patch set 1 V -1 06/18/18, 16:41
doesn'T work for me. still same issue -
Georg Ringer voted on patch set 1 V +1 CR +1 06/18/18, 16:43
-
Wouter Wolters voted on patch set 1 CR +1 06/18/18, 17:26
-
Mathias Brodala commented on patch set 1 06/19/18, 07:13
index.php:23Maybe stupid but since we perform a redirect afterwards anyways, do we need any of this at all? -
Benni Mack commented on patch set 1 06/19/18, 10:27
index.php:23Replyif we don't do it, it does not work :) we could simply do plain PHP here, of course. -
Mathias Brodala commented on patch set 1 06/19/18, 10:31
index.php:23ReplyI just had a closer look and you are right, there is a streak of dependencies on internals within the redirect() method via GeneralUtility. Since this file is deprecated anyways, there's not much value putting much more work here. So please forget what I said. ;-) -
Markus Klein voted on patch set 1 V +2 CR +2 06/20/18, 08:08
-
Markus Klein merged patch set 2 06/20/18, 08:08