Review main Abandoned

57271[WIP][BUGFIX] Insert arguments in form element default values

Mathias Brodala CR 0 V 0 Easy +11 −12 updated 10/02/18, 06:48

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Mathias Brodala uploaded patch set 1 06/20/18, 15:01

  2. TYPO3com voted on patch set 1 V -1 06/20/18, 15:10 Completed build in 09m 01s on Wed, 20 Jun, 05:10 PM Test Summary: 9 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24558

  3. Ralf Zimmermann commented on patch set 1 V -1 CR -1 06/22/18, 21:12

    Can't confirm this. Whenever a translation for an property exists within an xliff file it always overrules the property value. See https://docs.typo3.org/typo3cms/extensions/form/Concepts/FrontendRendering/Index.html#translate-form-definition "The property values are ignored if the process finds a proper entry within the translation file. As a result, the property values are overridden by the translated value." I tested this with two languages and the translation still works correct including the argument insertion.
  4. Mathias Brodala commented on patch set 1 CR -2 06/23/18, 09:09

    Thanks for digging into this, I'll debug my usecase once more and check if I simply messed up the translation files.
  5. Mathias Brodala abandoned the change 10/02/18, 06:48

    Issue should be fixed as described by Ralf.