Review main Merged

57272[TASK] Improve wording of upgrade wizards in Install Tool

Georg Ringer CR +2 V +2 Easy +6 −1 updated 06/21/18, 08:59

Commit message

Change the misleading headling "Available wizards" and
switch color of progress bar to success if 100% reached.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • David Bruchmann +1
    • Nicole Hummel +1
  • Verified V +2
    • Mathias Brodala +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Georg Ringer uploaded patch set 1 06/20/18, 15:04

  2. TYPO3com voted on patch set 1 V +1 06/20/18, 15:13 Completed build in 08m 44s on Wed, 20 Jun, 05:13 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24559

  3. David Bruchmann commented on patch set 1 CR +1 06/20/18, 15:19

    Looks OK. Simple and smart solution.
  4. David Bruchmann commented on patch set 1 06/20/18, 15:30

    The text-solution in Gerrit-review is good I think. Nevertheless I'd consider removing the progressbar if the status is 100% or turn the progressbar into green. Else it's optical not completely clear if there is still some verification in process.
  5. Georg Ringer uploaded patch set 2 06/20/18, 17:00

  6. TYPO3com voted on patch set 2 V +1 06/20/18, 17:08 Completed build in 07m 53s on Wed, 20 Jun, 07:08 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24565

  7. David Bruchmann commented on patch set 2 CR +1 06/21/18, 04:06

    Expected that the code is doing it's promise: Perfect!
  8. Nicole Hummel voted on patch set 2 V +1 CR +1 06/21/18, 08:56

  9. Mathias Brodala voted on patch set 2 V +2 CR +2 06/21/18, 08:58

  10. Mathias Brodala merged patch set 3 06/21/18, 08:59