Review main Merged

57276[BUGFIX] Do not link l18n_cfg restricted pages

Nicole Hummel CR +2 V +2 Easy +7 −0 updated 03/27/20, 11:15

Commit message

Prevent linking a page that is either restricted for the default
language or where any fallback is forbidden.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Mathias Brodala +1
  • Verified V +2
    • Stefan Neufeind +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Nicole Hummel uploaded patch set 1 06/20/18, 20:48

  2. TYPO3com voted on patch set 1 V +1 06/20/18, 20:56 Completed build in 07m 55s on Wed, 20 Jun, 10:56 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24568

  3. Mathias Brodala voted on patch set 1 CR +1 06/21/18, 09:16

  4. Stefan Neufeind voted on patch set 1 CR +1 06/23/18, 16:30

  5. Stefan Neufeind commented on patch set 1 V +2 CR +2 06/24/18, 21:54

    Peter tested the exact same code on 8.7 at https://review.typo3.org/57345
  6. Stefan Neufeind merged patch set 2 06/24/18, 21:54

  7. Benni Mack commented on patch set 2 08/24/18, 13:34

    PageLinkBuilder.php:63

    Bug: $language is not casted to (int) which will always fail in SQLite/MSSQL, tests would be good, so the testing suite could catch these things.
  8. Markus Klein commented on patch set 2 03/27/20, 11:15

    PageLinkBuilder.php:66 Unresolved

    This condition is wrong! We must use the requested language and not the language the page record just has. (which is always 0 if the a page is not translated) https://forge.typo3.org/issues/90850