Review main Merged

57280[TASK] Add .ddev to ignore

Harry Glatz CR +2 V +2 Easy +1 −0 updated 06/22/18, 19:46

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • Georg Ringer +1
  • Verified V +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Harry Glatz uploaded patch set 1 06/21/18, 09:13

  2. TYPO3com voted on patch set 1 V -1 06/21/18, 09:22 Completed build in 08m 56s on Thu, 21 Jun, 11:22 AM Test Summary: 1 of 32951 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24573

  3. Jörg Bösche commented on patch set 1 V +1 CR +1 06/21/18, 21:07

    The bamboo error (-1) doesnt depend on the gitignore change.
  4. TYPO3com voted on patch set 1 V +1 06/21/18, 21:15 Completed build in 12h 10m 12s on Thu, 21 Jun, 11:15 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24573

  5. Georg Ringer voted on patch set 1 V +1 CR +1 06/22/18, 04:28

  6. Marcus Schwemer commented on patch set 1 06/22/18, 15:55

    .gitignore:62

    I would add a comment line before, b/c it has nothing todo with the root .htaccess. The other question is, that all other directories have an asterisk behind the slash. Should we stick to this convention?
  7. Marcus Schwemer voted on patch set 1 V +1 06/22/18, 15:56

  8. Marcus Schwemer voted on patch set 1 CR -1 06/22/18, 15:56

  9. Andreas Kienast uploaded patch set 2 06/22/18, 19:35

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 06/22/18, 19:35

  11. Stefan Neufeind voted on patch set 2 V +1 CR +1 06/22/18, 19:37

  12. Georg Ringer voted on patch set 2 V +1 CR +1 06/22/18, 19:38

  13. TYPO3com voted on patch set 2 V +1 06/22/18, 19:46 Completed build in 10m 16s on Fri, 22 Jun, 09:46 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24659

  14. Andreas Kienast voted on patch set 2 V +2 CR +2 06/22/18, 19:46

  15. Andreas Kienast merged patch set 3 06/22/18, 19:46

  16. Andreas Kienast commented on patch set 3 06/22/18, 19:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9428a6892bfd4e5b5463fc9d663380c14a4b91b6