Review TYPO3_8-7 Merged

57283[BUGFIX] Try to translate given help text of select items

Mathias Brodala CR +2 V +2 Easy +5 −0 updated 06/30/18, 13:08

Commit message

Use the LanguageService for help texts of select items.
This can be tested with the element 'select_checkbox_3' of the
styleguide extension.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Tiefenbrunn +1
    • Jan Helke +1
    • Jörg Bösche +1
  • Verified V +2
    • Stefan Neufeind +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Mathias Brodala uploaded patch set 1 06/21/18, 10:17

  2. TYPO3com voted on patch set 1 V +1 06/21/18, 10:25 Completed build in 08m 05s on Thu, 21 Jun, 12:25 PM Test Summary: 58374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2577

  3. Georg Tiefenbrunn voted on patch set 1 CR +1 06/21/18, 11:22

  4. Jan Helke voted on patch set 1 CR +1 06/22/18, 12:31

  5. Stefan Neufeind voted on patch set 1 CR +1 06/22/18, 14:49

  6. Jörg Bösche voted on patch set 1 CR +1 06/27/18, 06:49

  7. Stefan Neufeind commented on patch set 1 V +2 CR +2 06/30/18, 13:08

    similar to master, retested on 8.7; seems we agreed on having a functionality like that (and we agreed on the backport)
  8. Stefan Neufeind merged patch set 2 06/30/18, 13:08