Review main Merged

57286[BUGFIX] Make functional tests run with sql_mode STRICT_TRANS_TABLES

Tymoteusz Motylewski CR +2 V +2 Easy +4 −4 updated 06/25/18, 15:35

Commit message

The text columns do not support default value.
Let's change the definition of the columns in irre_tutorial to varchar.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Stefan Neufeind +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Tymoteusz Motylewski uploaded patch set 1 06/21/18, 11:08

  2. TYPO3com voted on patch set 1 V +1 06/21/18, 11:17 Completed build in 08m 27s on Thu, 21 Jun, 01:17 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24584

  3. Wouter Wolters voted on patch set 1 CR +1 06/21/18, 12:43

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 06/22/18, 10:00

  5. Stefan Neufeind voted on patch set 1 V +2 CR +2 06/22/18, 18:54

  6. Stefan Neufeind merged patch set 2 06/22/18, 18:54

  7. Christian Kuhn commented on patch set 2 CR +1 06/25/18, 15:35

    thx tymek for fixing this. i did not think about the default value when i switched the field to text lately.