Review main Abandoned

57287[BUGFIX] Respect be user access restriction when fetching dependencies

Kevin Ditscheid CR 0 V 0 Normal +83 −2 updated 11/09/21, 21:33

Commit message

We want to respect the language access restrictions of the backend user
when fetching the dependencies in the DataMapProcessor, so the
DataMapper does not want to update records of a language the backend
user has no access to.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1419

  1. Kevin Ditscheid uploaded patch set 1 06/21/18, 12:22

  2. TYPO3com voted on patch set 1 V +1 06/21/18, 12:30 Completed build in 08m 11s on Thu, 21 Jun, 02:30 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24586

  3. Tymoteusz Motylewski commented on patch set 1 06/21/18, 13:31

    LanguageAccessRestriction.php:2

    please add strict mode.
  4. Kevin Ditscheid uploaded patch set 2 06/22/18, 07:10

  5. TYPO3com voted on patch set 2 V -1 06/22/18, 07:19 Completed build in 08m 03s on Fri, 22 Jun, 09:19 AM Test Summary: 3 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24599

  6. Kevin Ditscheid uploaded patch set 3 06/22/18, 07:48

  7. TYPO3com voted on patch set 3 V +1 06/22/18, 07:56 Completed build in 07m 57s on Fri, 22 Jun, 09:56 AM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24601

  8. Nicole Hummel commented on patch set 3 CR -1 08/27/18, 12:56

    As far as I understand the patch correct, limiting the value mapping to only allowed records/languages etc would resists in data inconsistency. IMHO the proper approach would be to disable any access change in DataMapProcessor and/or DataHandler to ensure new values are forwarded correctly.
  9. Joerg Kummer commented on patch set 3 10/28/18, 12:08

    Pending patch #58716 also creates class file \TYPO3\CMS\Database\Query\Restriction\LanguageAccessRestriction.php
  10. Benni Mack updated the commit message in patch set 4 12/14/18, 10:01

  11. Benni Mack commented on patch set 4 12/14/18, 10:01

    Updated the releases line, please re-apply your votes
  12. TYPO3com voted on patch set 4 V +1 12/14/18, 11:02 Completed build in 1h 00m 42s on Fri, 14 Dec, 12:02 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30697

  13. Kevin Ditscheid commented on patch set 4 CR -1 12/14/18, 11:07

    This needs to be adjusted for TYPO3 9 because it still uses pages_language_overlay table. Also Nicole, I do not know if limiting the language access at this point would lead to inconsistencies. Could you explain your scenario?
  14. Nicole Hummel commented on patch set 4 12/14/18, 11:38

    As far as I remember, I refer to the l10n_source updates. If a value in the default language is changed, it might be necessary to also update different language records that obtain their values from the default one. I'm not sure if this patch will break the l10n_source handling then. Furthermore I think there might be updated tests for backend users limited to one language only.
  15. Susi Moog commented on patch set 4 10/25/19, 18:48

    I can reproduce the issue, however I think this change really would benefit from additional tests to ensure we do not break anything else. Can you do that?
  16. Benni Mack updated the commit message in patch set 5 05/25/20, 18:42

  17. TYPO3com voted on patch set 5 V -1 05/25/20, 18:50 Completed build in 49s on Mon, 25 May, 06:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3529

  18. Christian Kuhn commented on patch set 5 11/09/21, 21:33

    Hey. I'm gonna abandon this change for now: While it seems the issue may still be legit, this change will probably not make it without serious test coverage. Also, the patch is stalled for a long while and no active work has been done in this area. It is of course always valid to resurrect the change when work continues. I'll set the forge issue to 'new' for now.
  19. Christian Kuhn abandoned the change 11/09/21, 21:33