Review main Abandoned

57290[BUGFIX] Resolve `LLL` references for overloaded help texts

Andreas Kienast CR 0 V 0 Easy +2 −2 updated 06/22/18, 22:36

Commit message

The method `BackendUtility::wrapInHelp()` supports overloading help texts
by providing an array, as used by FormEngine's SelectCheckBoxElement.
This patch allows to use LLL-based labels now, which may be necessary
when using this feature by providing the fourth parameter in the `items`
array in TCA.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 910

  1. Andreas Kienast uploaded patch set 1 06/22/18, 09:00

  2. Christoph Schwob voted on patch set 1 V +1 CR +1 06/22/18, 09:03

  3. TYPO3com voted on patch set 1 V +1 06/22/18, 09:08 Completed build in 08m 16s on Fri, 22 Jun, 11:08 AM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24602

  4. Clemens Riccabona voted on patch set 1 CR +1 06/22/18, 10:50

  5. Wouter Wolters voted on patch set 1 CR +1 06/22/18, 18:29

  6. Michael Oehlhof voted on patch set 1 CR +1 06/22/18, 21:37

  7. Susi Moog commented on patch set 1 CR -1 06/22/18, 22:10

    on it.
  8. Susi Moog commented on patch set 1 CR -2 06/22/18, 22:22

    Cannot reproduce the bug at all, with formengine the items (and help texts) already have resolved language labels (with the configuration from the issue) - please recheck if the bug still appears without the patch.
  9. Susi Moog commented on patch set 1 06/22/18, 22:36

  10. Susi Moog abandoned the change 06/22/18, 22:36