Review main Abandoned

57292[FEATURE] Allow specifying a CURL_IPRESOLVE variant for cURL requests.

TYPO3com CR 0 V 0 Easy +4 −0 updated 10/28/18, 10:42

Commit message

This allows specifying an IP resolve method for cURL requests in
`GeneralUtility::getUrl`.

That change can prevent weird issues with certain SSL/TLS certificates
where this function fails although when specifying the correct
[CURL_IPRESOLVE](http://php.net/manual/en/function.curl-setopt.php) type,
it does indeed work.

This should also be - and also can - backported to the TYPO3 v6.2 branch.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 13

  1. TYPO3com uploaded patch set 1 06/22/18, 11:50

  2. TYPO3com voted on patch set 1 V -1 06/22/18, 11:50 Completed build in 06s on Fri, 22 Jun, 01:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24604

  3. Benni Mack abandoned the change 10/28/18, 10:42

    Hi Robin, we've overcome this issue by adding Guzzle library to TYPO3 v8. This change is targeted to master, where this is obsolete. Please consider adding this to v7 branch or contact TYPO3 GmbH for 6.2, as the TYPO3 core team does not maintain 6.2 anymore (and v7 only for another month)