Review main Merged

57294[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths

Claus Due CR +2 V +2 Easy +7 −14 updated 06/23/18, 19:39

Commit message

This patch avoids calling GeneralUtility::removeDotsFromTs
on the entire TS array, instead selectively calling it only on
the sub-array and only if a sub-array was actually resolved.

In my extremely small testing setup this patch avoids 1,100
calls in FE and 6,000 calls in BE (in page module with fluid
previews being rendered).

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Fabien Udriot +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Claus Due uploaded patch set 1 06/22/18, 13:17

  2. TYPO3com voted on patch set 1 V +1 06/22/18, 13:26 Completed build in 08m 57s on Fri, 22 Jun, 03:26 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24611

  3. Stefan Neufeind voted on patch set 1 V +1 CR +1 06/22/18, 18:52

  4. Markus Klein commented on patch set 1 06/22/18, 21:26

    TemplatePaths.php:97

    why are you dropping the runtime cache here?
  5. Fabien Udriot commented on patch set 1 CR +1 06/22/18, 21:37

    TemplatePaths.php:97 Reply

    Not that necessary I am presuming. We are within a protected method that is only called once within that class and we are not in a Singleton Class where we could benefit from a runtime cache. Furthermore $this->getConfigurationManager has its own internal cache.
  6. Claus Due commented on patch set 1 06/22/18, 22:21

    TemplatePaths.php:97 Reply

    That is exactly right - on all points.
  7. Jigal van Hemert voted on patch set 1 V +2 CR +2 06/23/18, 19:38

  8. Jigal van Hemert merged patch set 2 06/23/18, 19:38

  9. Jigal van Hemert commented on patch set 2 06/23/18, 19:39

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f5ed1f074c4a2e69f926cddae8a005ac836abc2b