57294[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Fabien Udriot +1
-
Verified V +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 89
-
Claus Due uploaded patch set 1 06/22/18, 13:17
-
TYPO3com voted on patch set 1 V +1 06/22/18, 13:26 Completed build in 08m 57s on Fri, 22 Jun, 03:26 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24611
-
Stefan Neufeind voted on patch set 1 V +1 CR +1 06/22/18, 18:52
-
Markus Klein commented on patch set 1 06/22/18, 21:26
-
Fabien Udriot commented on patch set 1 CR +1 06/22/18, 21:37
TemplatePaths.php:97ReplyNot that necessary I am presuming. We are within a protected method that is only called once within that class and we are not in a Singleton Class where we could benefit from a runtime cache. Furthermore $this->getConfigurationManager has its own internal cache. -
Claus Due commented on patch set 1 06/22/18, 22:21
TemplatePaths.php:97ReplyThat is exactly right - on all points. -
Jigal van Hemert voted on patch set 1 V +2 CR +2 06/23/18, 19:38
-
Jigal van Hemert merged patch set 2 06/23/18, 19:38
-
Jigal van Hemert commented on patch set 2 06/23/18, 19:39
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f5ed1f074c4a2e69f926cddae8a005ac836abc2b
TemplatePaths.php:97