57297[BUGFIX] Fetch Vimeo preview in higher quality
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- anonymized-54557 +1
- Josef Glatz +1
- Guido Schmechel +1
- Alexander Stehlik +1
- Michael Oehlhof +1
-
Verified V +2
- Susi Moog +2
- anonymized-54557 +1
- Josef Glatz +1
- Alexander Stehlik +1
- Michael Oehlhof +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1719
-
Frans Saris uploaded patch set 1 06/22/18, 14:13
-
TYPO3com voted on patch set 1 V +1 06/22/18, 14:24 Completed build in 10m 16s on Fri, 22 Jun, 04:24 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24619
-
Frans Saris updated the commit message in patch set 2 06/22/18, 14:35
-
TYPO3com voted on patch set 2 V +1 06/22/18, 14:43 Completed build in 08m 00s on Fri, 22 Jun, 04:43 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24620
-
Stefan Neufeind commented on patch set 2 06/22/18, 15:36
I've tried to embed a textmedia with a vimeo-video of 2000px. In that element it seems to fetch a preview-image of 2000 (actually returned 1920 for me) even without the patch. How can I test the issue you saw? -
Frans Saris commented on patch set 2 06/22/18, 16:50
Also for the video from the issue? I tested with some random video and got different results. -
Frans Saris commented on patch set 2 06/22/18, 16:55
Tried https://vimeo.com/4981022 Got a video with a width less then 1000px first and after it was larger. Not 2400 but larger. -
Alexander Stehlik voted on patch set 2 V +1 CR +1 06/22/18, 19:55
-
anonymized-54557 voted on patch set 2 V +1 CR +1 06/22/18, 21:30
-
Michael Oehlhof voted on patch set 2 V +1 CR +1 06/22/18, 21:46
-
Robert Vierke commented on patch set 2 06/22/18, 21:54
Are you sure to take the width parameter? I'm not a vimeo pro, but the width parameter only sets the pixel width of the rendered video. I think you want the quality param. But if the video isn't available in the quality, the default behavior is used. The quality, if not given in the url, is by default "auto". https://developer.vimeo.com/apis/oembed https://help.vimeo.com/hc/en-us/articles/360001494447-Using-Player-Parameters -
Alexander Stehlik commented on patch set 2 06/22/18, 22:00
@Robert: the patch is about the preview image of the video which can be downloaded in a larger version when the width parameter is provided. Compare the sizes of the images returned in "thumbnail_url" between these URLs: https://vimeo.com/api/oembed.json?width=2048&url=https://vimeo.com/262998843 https://vimeo.com/api/oembed.json?url=https://vimeo.com/262998843 The image in the first request has a higher resolution. -
Guido Schmechel commented on patch set 2 CR +1 06/23/18, 04:14
Is this secure that this width (2048) will always be available? I think a follow up with fallback image solution like Youtube would be a good idea? -
Frans Saris commented on patch set 2 06/23/18, 05:33
@guido the fallback is automatically provided by Vimeo. We don't need to do anything on our side -
Josef Glatz voted on patch set 2 CR +1 06/23/18, 05:59
-
Josef Glatz voted on patch set 2 V +1 06/23/18, 12:31
-
Susi Moog voted on patch set 2 V +2 CR +2 06/23/18, 14:28
-
Susi Moog merged patch set 3 06/23/18, 14:28
-
Susi Moog commented on patch set 3 06/23/18, 14:29
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 70280165787d733f500d261110e0d98bcdcce465