57298[TASK] Recommend lockSSL option in reports module
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Georg Ringer +2
- Mathias Brodala +1
-
Verified V +2
- Stefan Neufeind +2
- Georg Ringer +2
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+30 −0
- typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf2+6 −0
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php5+1 −11
- typo3/sysext/saltedpasswords/Resources/Private/Language/locallang.xlf1+0 −13
Review log 2327
Show 2 earlier messages
-
TYPO3com voted on patch set 1 V +1 06/22/18, 15:01 Completed build in 08m 20s on Fri, 22 Jun, 05:01 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24622
-
Björn Jacob commented on patch set 1 06/22/18, 15:04
locallang.xlf:83I am not a native speaker but I think one should not use short forms in written context. Here is my proposal: "You are already accessing the TYPO3 backend via HTTPS. It 'i therefore recommended to enable the ($TYPO3_CONF_VARS['BE']['lockSSL']) option." I have also removed the unnecessary "also". -
Josef Glatz commented on patch set 1 06/22/18, 15:06
Thx for your feedback. I'm on it. Mathias suggested to move those info to the HTTPS check. I'm on it -
Stefan Neufeind commented on patch set 1 V +1 CR +1 06/22/18, 15:06
with or without this patch it shows up as "OK - During the configuration check of saltedpasswords the following issues have been found". Without the patch it's a warning (orange) and with the patch there it's green with "additional information" provided. Would be fine with me imho. -
Mathias Brodala commented on patch set 1 CR -1 06/22/18, 15:07
An update will be posted. -
Josef Glatz voted on patch set 1 CR -1 06/22/18, 19:19
-
Josef Glatz uploaded patch set 2 06/22/18, 21:20
-
Josef Glatz updated the commit message in patch set 3 06/22/18, 21:22
-
Georg Ringer voted on patch set 3 V +1 CR +1 06/22/18, 21:30
-
TYPO3com voted on patch set 2 V +1 06/22/18, 21:34 Completed build in 14m 17s on Fri, 22 Jun, 11:34 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24690
-
TYPO3com voted on patch set 3 V +1 06/22/18, 21:39 Completed build in 16m 29s on Fri, 22 Jun, 11:39 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24692
-
Mathias Brodala commented on patch set 3 CR -1 06/22/18, 21:52
Please make the small changes as requested.locallang_reports.xlf:136$GLOBALS['TYPO3_CONF_VARS']locallang_reports.xlf:136... the ...ExtensionManagerConfigurationUtility.php:195Is this really related? -
Josef Glatz commented on patch set 3 CR -1 06/22/18, 21:59
ExtensionManagerConfigurationUtility.php:195Reply> Is this really related? Do you think we should leave it as it is or/and doing that in another patch? (Georg suggested it because: - suggesting rsaauth is actually a bad idea (I'm not 100% sure if it's a good idea to remove this suggestion) - at least the info about lockSSL get's moved into an own check with that patch -
Josef Glatz uploaded patch set 4 06/22/18, 22:01
-
TYPO3com voted on patch set 4 V +1 06/22/18, 22:10 Completed build in 08m 59s on Sat, 23 Jun, 12:10 AM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24704
-
Mathias Brodala voted on patch set 4 CR +1 06/22/18, 22:23
-
Stefan Neufeind voted on patch set 4 V +1 CR +1 06/22/18, 22:35
-
Georg Ringer voted on patch set 4 V +1 CR +1 06/22/18, 22:55
-
Georg Ringer voted on patch set 4 V +2 CR +2 06/22/18, 22:56
-
Stefan Neufeind merged patch set 5 06/22/18, 23:04
-
Stefan Neufeind voted on patch set 5 V +2 CR +2 06/22/18, 23:04
-
Tymoteusz Motylewski commented on patch set 5 06/26/18, 20:26
post -1, see inline commentsExtensionManagerConfigurationUtility.php:195now, in this execution patch the variable $problems is undefined.ExtensionManagerConfigurationUtility.php:231$problems might not be defined. -
Mathias Brodala commented on patch set 5 06/27/18, 07:31
ExtensionManagerConfigurationUtility.php:231ReplyThat's true but actually not a problem since renderMessage() checks if $this->problems is not empty which deals both with an empty array and null. But yes, initializing this with an empty array would be cleaner. -
Josef Glatz commented on patch set 5 07/13/18, 11:23
> (1 comment) I don't get the full problem. Do we have t odo something here? -
Mathias Brodala commented on patch set 5 07/13/18, 12:20
> > (1 comment) > > I don't get the full problem. Do we have t odo something here? A tiny change for cleanup could done, yeah.