Review main Merged

57298[TASK] Recommend lockSSL option in reports module

Josef Glatz CR +2 V +2 Normal +37 −24 updated 07/13/18, 12:20

Commit message

Introduce a new status for $GLOBALS['TYPO3_CONF_VARS']['BE']['lockSSL'].

The new check is only shown if the backend is accessed through
HTTPS.

The information about the usage of ext:rsaauth is removed within
the ext:saltedpasswords status message, because it is marked as
deprecated.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Ringer +2
    • Mathias Brodala +1
  • Verified V +2
    • Stefan Neufeind +2
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2327

Show 2 earlier messages
  1. Josef Glatz uploaded patch set 1 06/22/18, 14:53

  2. Mathias Brodala commented on patch set 1 06/22/18, 14:57

    I think this makes more sense in the Reports module.
  1. TYPO3com voted on patch set 1 V +1 06/22/18, 15:01 Completed build in 08m 20s on Fri, 22 Jun, 05:01 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24622

  2. Björn Jacob commented on patch set 1 06/22/18, 15:04

    locallang.xlf:83

    I am not a native speaker but I think one should not use short forms in written context. Here is my proposal: "You are already accessing the TYPO3 backend via HTTPS. It 'i therefore recommended to enable the ($TYPO3_CONF_VARS['BE']['lockSSL']) option." I have also removed the unnecessary "also".
  3. Josef Glatz commented on patch set 1 06/22/18, 15:06

    Thx for your feedback. I'm on it. Mathias suggested to move those info to the HTTPS check. I'm on it
  4. Stefan Neufeind commented on patch set 1 V +1 CR +1 06/22/18, 15:06

    with or without this patch it shows up as "OK - During the configuration check of saltedpasswords the following issues have been found". Without the patch it's a warning (orange) and with the patch there it's green with "additional information" provided. Would be fine with me imho.
  5. Mathias Brodala commented on patch set 1 CR -1 06/22/18, 15:07

    An update will be posted.
  6. Josef Glatz voted on patch set 1 CR -1 06/22/18, 19:19

  7. Josef Glatz uploaded patch set 2 06/22/18, 21:20

  8. Josef Glatz updated the commit message in patch set 3 06/22/18, 21:22

  9. Georg Ringer voted on patch set 3 V +1 CR +1 06/22/18, 21:30

  10. TYPO3com voted on patch set 2 V +1 06/22/18, 21:34 Completed build in 14m 17s on Fri, 22 Jun, 11:34 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24690

  11. TYPO3com voted on patch set 3 V +1 06/22/18, 21:39 Completed build in 16m 29s on Fri, 22 Jun, 11:39 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24692

  12. Mathias Brodala commented on patch set 3 CR -1 06/22/18, 21:52

    Please make the small changes as requested.

    locallang_reports.xlf:136

    $GLOBALS['TYPO3_CONF_VARS']

    locallang_reports.xlf:136

    ... the ...

    ExtensionManagerConfigurationUtility.php:195

    Is this really related?
  13. Josef Glatz commented on patch set 3 CR -1 06/22/18, 21:59

    ExtensionManagerConfigurationUtility.php:195 Reply

    > Is this really related? Do you think we should leave it as it is or/and doing that in another patch? (Georg suggested it because: - suggesting rsaauth is actually a bad idea (I'm not 100% sure if it's a good idea to remove this suggestion) - at least the info about lockSSL get's moved into an own check with that patch
  14. Josef Glatz uploaded patch set 4 06/22/18, 22:01

  15. TYPO3com voted on patch set 4 V +1 06/22/18, 22:10 Completed build in 08m 59s on Sat, 23 Jun, 12:10 AM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24704

  16. Mathias Brodala voted on patch set 4 CR +1 06/22/18, 22:23

  17. Stefan Neufeind voted on patch set 4 V +1 CR +1 06/22/18, 22:35

  18. Georg Ringer voted on patch set 4 V +1 CR +1 06/22/18, 22:55

  19. Georg Ringer voted on patch set 4 V +2 CR +2 06/22/18, 22:56

  20. Stefan Neufeind merged patch set 5 06/22/18, 23:04

  21. Stefan Neufeind voted on patch set 5 V +2 CR +2 06/22/18, 23:04

  22. Tymoteusz Motylewski commented on patch set 5 06/26/18, 20:26

    post -1, see inline comments

    ExtensionManagerConfigurationUtility.php:195

    now, in this execution patch the variable $problems is undefined.

    ExtensionManagerConfigurationUtility.php:231

    $problems might not be defined.
  23. Mathias Brodala commented on patch set 5 06/27/18, 07:31

    ExtensionManagerConfigurationUtility.php:231 Reply

    That's true but actually not a problem since renderMessage() checks if $this->problems is not empty which deals both with an empty array and null. But yes, initializing this with an empty array would be cleaner.
  24. Josef Glatz commented on patch set 5 07/13/18, 11:23

    > (1 comment) I don't get the full problem. Do we have t odo something here?
  25. Mathias Brodala commented on patch set 5 07/13/18, 12:20

    > > (1 comment) > > I don't get the full problem. Do we have t odo something here? A tiny change for cleanup could done, yeah.