57300[TASK] Use trait for public method access deprecation
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Alexander Stehlik +1
- Sebastian Hofer +1
-
Verified V +2
- Andreas Wolf +2
- Alexander Stehlik +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php2+11 −9
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+11 −9
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+26 −18
- typo3/sysext/backend/Classes/Controller/File/FileController.php+13 −14
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+21 −49
Review log 1928
Show 23 earlier messages
-
Mathias Brodala uploaded patch set 1 06/22/18, 16:14
-
TYPO3com voted on patch set 1 V -1 06/22/18, 16:15 Completed build in 07s on Fri, 22 Jun, 06:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24633
-
Mathias Brodala rebased onto patch set 2 06/22/18, 16:16
-
TYPO3com commented on patch set 2 06/22/18, 16:16 Completed build in 06s on Fri, 22 Jun, 06:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24634
-
Mathias Brodala uploaded patch set 3 06/22/18, 16:21
-
TYPO3com voted on patch set 3 V -1 06/22/18, 16:21 Completed build in 09s on Fri, 22 Jun, 06:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24635
-
Mathias Brodala uploaded patch set 4 06/22/18, 16:22
-
TYPO3com voted on patch set 4 V -1 06/22/18, 16:30 Completed build in 07m 59s on Fri, 22 Jun, 06:30 PM Test Summary: 1 of 32948 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24636
-
TYPO3com voted on patch set 4 V +1 06/22/18, 16:32 Completed build in 18m 12s on Fri, 22 Jun, 06:32 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24636
-
Mathias Brodala updated the commit message in patch set 5 06/22/18, 16:33
-
TYPO3com voted on patch set 5 V +1 06/22/18, 16:42 Completed build in 09m 02s on Fri, 22 Jun, 06:42 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24638
-
Mathias Brodala commented on patch set 6 06/22/18, 18:55
Published edit on patch set 5. -
TYPO3com voted on patch set 6 V +1 06/22/18, 19:05 Completed build in 09m 28s on Fri, 22 Jun, 09:05 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24652
-
Alexander Stehlik voted on patch set 6 CR +1 06/22/18, 20:05
-
Alexander Stehlik voted on patch set 6 V +1 06/22/18, 21:11
-
Sebastian Hofer voted on patch set 6 CR +1 06/22/18, 22:34
-
Andreas Wolf rebased onto patch set 7 06/22/18, 22:35
-
TYPO3com voted on patch set 7 V +1 06/22/18, 22:47 Completed build in 12m 16s on Sat, 23 Jun, 12:47 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24715
-
Sebastian Hofer voted on patch set 7 CR +1 06/22/18, 23:05
-
Mathias Brodala uploaded patch set 8 06/22/18, 23:28
-
Sebastian Hofer voted on patch set 8 CR +1 06/22/18, 23:36
-
TYPO3com voted on patch set 8 V +1 06/22/18, 23:38 Completed build in 10m 03s on Sat, 23 Jun, 01:38 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24728
-
Susi Moog commented on patch set 8 06/22/18, 23:42
ElementInformationController.php:57is it a good idea to make these private? with xclasses and potential third party code extending these classes the deprecation will not be used anymore, will it? -
Mathias Brodala commented on patch set 8 06/23/18, 08:41
ElementInformationController.php:57ReplyI just did a quick test and making this private actually _ensures_ that there are deprecation messages even in extending classes: https://3v4l.org/Ejdue They are not even able to overwrite the deprecations defined in the base class. So we actually _must_ use "private" here. -
Mathias Brodala commented on patch set 8 06/23/18, 09:01
I've pushed https://review.typo3.org/57333 to discuss this separately. -
Alexander Stehlik voted on patch set 8 V +1 CR +1 06/23/18, 10:16
-
Andreas Wolf voted on patch set 8 V +2 CR +2 06/25/18, 18:54
-
Andreas Wolf merged patch set 9 06/25/18, 18:54