Review main Merged

57302[TASK] Add details for named keys in translation arguments

TYPO3com CR +2 V +2 Easy +19 −3 updated 06/22/18, 20:50

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Björn Jacob +1
  • Verified V +2
    • Stefan Neufeind +2
    • Björn Jacob +1

Issues 1

Files 1

Review log 913

  1. TYPO3com uploaded patch set 1 06/22/18, 18:16

  2. Mathias Brodala rebased onto patch set 2 06/22/18, 18:18

  3. TYPO3com voted on patch set 1 V +1 06/22/18, 18:26 Completed build in 09m 11s on Fri, 22 Jun, 08:26 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24643

  4. TYPO3com voted on patch set 2 V +1 06/22/18, 18:26 Completed build in 08m 50s on Fri, 22 Jun, 08:27 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24644

  5. Björn Jacob commented on patch set 2 06/22/18, 19:33

    Index.rst:1116

    received

    Index.rst:1131

    I don't get this sentence tbh. Please rephrase.

    Index.rst:1172

    "As it can be seen"

    Index.rst:1174

    I would remove this word "before". Not needed IMHO.
  6. Mathias Brodala commented on patch set 3 06/22/18, 19:42

    Published edit on patch set 2.
  7. Mathias Brodala commented on patch set 2 06/22/18, 19:42

    Index.rst:1116 Reply

    Done

    Index.rst:1131 Reply

    Done

    Index.rst:1172 Reply

    Done

    Index.rst:1174 Reply

    Done
  8. Björn Jacob voted on patch set 3 V +1 CR +1 06/22/18, 19:44

  9. Stefan Neufeind voted on patch set 3 V +2 CR +2 06/22/18, 19:47

  10. Stefan Neufeind merged patch set 4 06/22/18, 19:47

  11. TYPO3com voted on patch set 3 V +1 06/22/18, 19:56 Completed build in 14m 20s on Fri, 22 Jun, 09:56 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24663

  12. Ralf Zimmermann commented on patch set 4 06/22/18, 20:49

    Post -1 "Here it makes sense to use YAML hashes instead of YAML lists to give sections named keys." This would break the form editor. You can not use "hashes" as sections named keys. That would require an "sorting" property which is not available for now. The documentet solution is only working if you don't need/use the form editor.
  13. Mathias Brodala commented on patch set 4 06/22/18, 20:50

    > Post -1 > "Here it makes sense to use > YAML hashes instead of YAML lists to give sections named keys." > > This would break the form editor. You can not use "hashes" as > sections named keys. That would require an "sorting" property which > is not available for now. The documentet solution is only working > if you don't need/use the form editor. Can you post another change which mentions this?