Review main Merged

57311[TASK] Open modals in install tool with better sizes

Frank Nägler CR +2 V +2 Normal +74 −88 updated 06/22/18, 20:59

Commit message

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Jürgen Venne +1
  • Verified V +2
    • Benjamin Kott +2
    • Jürgen Venne +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 79

  1. Frank Nägler uploaded patch set 1 06/22/18, 20:15

  2. TYPO3com voted on patch set 1 V -1 06/22/18, 20:25 Completed build in 09m 27s on Fri, 22 Jun, 10:25 PM Test Summary: 1 of 32954 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24669

  3. Jürgen Venne commented on patch set 1 V -1 CR -1 06/22/18, 20:40

    Cards.html:26

    If there are many admin users the drop-down list is cut.
  4. Jürgen Venne uploaded patch set 2 06/22/18, 20:43

  5. Jürgen Venne commented on patch set 2 V +1 CR +1 06/22/18, 20:51

    Changed modal size in settingsCards for manage system maintainers. Now looks good.
  6. Benjamin Kott voted on patch set 2 V +1 CR +1 06/22/18, 20:55

  7. TYPO3com voted on patch set 2 V +1 06/22/18, 20:55 Completed build in 11m 43s on Fri, 22 Jun, 10:55 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24675

  8. Benjamin Kott voted on patch set 2 V +2 CR +2 06/22/18, 20:59

  9. Benjamin Kott merged patch set 3 06/22/18, 20:59