57319[BUGFIX] Remove reset of GFX/processor_effects to -1
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Fabien Udriot +1
- Mathias Brodala +1
-
Verified V +2
- Andreas Wolf +2
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1316
-
Marc Willmann uploaded patch set 1 06/22/18, 21:48
-
TYPO3com voted on patch set 1 V -1 06/22/18, 22:00 Completed build in 12m 00s on Sat, 23 Jun, 12:00 AM Test Summary: 3 of 32965 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24699
-
Marc Willmann uploaded patch set 2 06/22/18, 22:52
-
TYPO3com voted on patch set 2 V +1 06/22/18, 23:01 Completed build in 09m 04s on Sat, 23 Jun, 01:01 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24719
-
Susi Moog voted on patch set 2 CR +1 06/22/18, 23:13
-
Stefan Neufeind updated the commit message in patch set 3 06/22/18, 23:14
-
Stefan Neufeind commented on patch set 3 06/22/18, 23:15
As discussed this is more a bugfix. Also this seems to be related to 8.7 as well, just by looking at the code. -
TYPO3com voted on patch set 3 V +1 06/22/18, 23:23 Completed build in 08m 35s on Sat, 23 Jun, 01:23 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24723
-
Fabien Udriot voted on patch set 3 CR +1 06/23/18, 08:09
-
Mathias Brodala voted on patch set 3 CR +1 06/23/18, 08:41
-
Mathias Brodala voted on patch set 3 V +1 06/23/18, 08:42
-
Andreas Wolf voted on patch set 3 V +2 CR +2 06/23/18, 09:52
-
Andreas Wolf merged patch set 4 06/23/18, 09:52
-
Andreas Wolf commented on patch set 4 06/23/18, 09:55
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 910989df2fcbde113562124cf3b8f56e7fba84f6 -
Tymoteusz Motylewski commented on patch set 4 06/26/18, 20:22
post -1, see inline commentSilentConfigurationUpgradeService.php:511this variable $currentProcessorEffectsValue is now dead code. Can we remove the whole try -> catch? -
Mathias Brodala commented on patch set 4 06/27/18, 07:28
SilentConfigurationUpgradeService.php:511ReplyGood catch, see https://review.typo3.org/57391