Review main Merged

57319[BUGFIX] Remove reset of GFX/processor_effects to -1

Marc Willmann CR +2 V +2 Easy +1 −7 updated 06/27/18, 07:28

Commit message

When entering the Install Tool and the GFX/processor is set to
GraphicsMagick the value for GFX/processor_effects is reset to -1,
overwriting any value that might have been set before.
Also adjust tests for the new expectations.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Fabien Udriot +1
    • Mathias Brodala +1
  • Verified V +2
    • Andreas Wolf +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Marc Willmann uploaded patch set 1 06/22/18, 21:48

  2. TYPO3com voted on patch set 1 V -1 06/22/18, 22:00 Completed build in 12m 00s on Sat, 23 Jun, 12:00 AM Test Summary: 3 of 32965 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24699

  3. Marc Willmann uploaded patch set 2 06/22/18, 22:52

  4. TYPO3com voted on patch set 2 V +1 06/22/18, 23:01 Completed build in 09m 04s on Sat, 23 Jun, 01:01 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24719

  5. Susi Moog voted on patch set 2 CR +1 06/22/18, 23:13

  6. Stefan Neufeind updated the commit message in patch set 3 06/22/18, 23:14

  7. Stefan Neufeind commented on patch set 3 06/22/18, 23:15

    As discussed this is more a bugfix. Also this seems to be related to 8.7 as well, just by looking at the code.
  8. TYPO3com voted on patch set 3 V +1 06/22/18, 23:23 Completed build in 08m 35s on Sat, 23 Jun, 01:23 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24723

  9. Fabien Udriot voted on patch set 3 CR +1 06/23/18, 08:09

  10. Mathias Brodala voted on patch set 3 CR +1 06/23/18, 08:41

  11. Mathias Brodala voted on patch set 3 V +1 06/23/18, 08:42

  12. Andreas Wolf voted on patch set 3 V +2 CR +2 06/23/18, 09:52

  13. Andreas Wolf merged patch set 4 06/23/18, 09:52

  14. Andreas Wolf commented on patch set 4 06/23/18, 09:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 910989df2fcbde113562124cf3b8f56e7fba84f6
  15. Tymoteusz Motylewski commented on patch set 4 06/26/18, 20:22

    post -1, see inline comment

    SilentConfigurationUpgradeService.php:511

    this variable $currentProcessorEffectsValue is now dead code. Can we remove the whole try -> catch?
  16. Mathias Brodala commented on patch set 4 06/27/18, 07:28

    SilentConfigurationUpgradeService.php:511 Reply