Review TYPO3_8-7 Merged

57327[BUGFIX] Remove Byte Order Mark from TypoScript includes

Mathias Brodala CR +2 V +2 Easy +49 −0 updated 06/22/18, 23:28

Commit message

If TypoScript files have a Byte Order Mark (BOM) set, the TypoScript
parser may fail as the invisible characters disturb the parsing process.

The BOM gets removed from the TypoScript strings with this patch.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 3

Review log 46

  1. Mathias Brodala uploaded patch set 1 06/22/18, 22:40

  2. TYPO3com voted on patch set 1 V -1 06/22/18, 22:55 Completed build in 14m 56s on Sat, 23 Jun, 12:55 AM Test Summary: 4 of 58799 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2592

  3. Andreas Kienast uploaded patch set 2 06/22/18, 23:13

  4. Stefan Neufeind commented on patch set 2 V +2 CR +2 06/22/18, 23:17

    retested on 8.7
  5. Stefan Neufeind merged patch set 3 06/22/18, 23:17

  6. TYPO3com voted on patch set 2 V +1 06/22/18, 23:28 Completed build in 15m 37s on Sat, 23 Jun, 01:28 AM Test Summary: 58398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2593