Review main Merged

57328[FEATURE] Use HTML5 field types and attributes in FormEngine

Andreas Kienast CR +2 V +2 Easy +38 −1 updated 06/23/18, 09:23

Commit message

The FormEngine renders now HTML5 specific field types and attributes
based on its `eval` config.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Patrick Schriner +1
    • Susi Moog +1
  • Verified V +2
    • Mathias Brodala +2
    • Patrick Schriner +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Andreas Kienast uploaded patch set 1 06/22/18, 23:00

  2. TYPO3com voted on patch set 1 V +1 06/22/18, 23:09 Completed build in 08m 22s on Sat, 23 Jun, 01:09 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24721

  3. Mathias Brodala commented on patch set 2 06/22/18, 23:22

    Published edit on patch set 1.
  4. Mathias Brodala commented on patch set 3 06/22/18, 23:23

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V +1 06/22/18, 23:30 Completed build in 08m 13s on Sat, 23 Jun, 01:30 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24725

  6. TYPO3com voted on patch set 3 V +1 06/22/18, 23:35 Completed build in 11m 51s on Sat, 23 Jun, 01:35 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24726

  7. Susi Moog voted on patch set 3 V +1 CR +1 06/22/18, 23:39

  8. Patrick Schriner commented on patch set 3 V +1 06/22/18, 23:41

    InputTextElement.php:221

    (int) please

    InputTextElement.php:224

    (int) please
  9. Andreas Kienast uploaded patch set 4 06/22/18, 23:53

  10. Susi Moog voted on patch set 4 V +1 CR +1 06/22/18, 23:54

  11. TYPO3com voted on patch set 4 V +1 06/23/18, 00:03 Completed build in 10m 30s on Sat, 23 Jun, 02:03 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24732

  12. Mathias Brodala voted on patch set 4 V +1 CR +1 06/23/18, 08:52

  13. Patrick Schriner voted on patch set 4 V +1 CR +1 06/23/18, 09:13

  14. Mathias Brodala voted on patch set 4 V +2 CR +2 06/23/18, 09:23

  15. Mathias Brodala merged patch set 5 06/23/18, 09:23