Review main Merged

57331[FEATURE] Add support to CurrencyViewHelper for mdash

Timo Poppinga CR +2 V +2 Hard +196 −278 updated 06/23/18, 14:41

Commit message

If the option `useDash` is set and a round value is given,
the decimal place is rendered as a dash.
Do tests refactor, using value data provider for all tests.

Review

  • Code review CR +2
    • Susi Moog +2
    • Marcus Schwemer +1
    • Frans Saris +1
  • Verified V +2
    • Susi Moog +2
    • Marcus Schwemer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1823

  1. Timo Poppinga uploaded patch set 1 06/22/18, 23:51

  2. Andreas Kienast commented on patch set 1 CR -1 06/22/18, 23:56

    On it
  3. TYPO3com voted on patch set 1 V +1 06/23/18, 00:01 Completed build in 09m 39s on Sat, 23 Jun, 02:01 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24731

  4. Andreas Kienast uploaded patch set 2 06/23/18, 00:04

  5. TYPO3com voted on patch set 2 V +1 06/23/18, 00:13 Completed build in 09m 03s on Sat, 23 Jun, 02:13 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24735

  6. Guido Schmechel commented on patch set 2 06/23/18, 04:03

    Maybe a short description for the commit message like in the rst file?

    CurrencyViewHelper.php:105

    Maybe GeneralUTility::trimExplode() instead of explode?
  7. Frans Saris commented on patch set 2 06/23/18, 07:11

    CurrencyViewHelper.php:105 Reply

    trimExplode isn't needed as we know the format is ok as result of the number_format above
  8. Mathias Brodala commented on patch set 2 06/23/18, 08:46

    CurrencyViewHelper.php:74

    Please rename this to "useDash". Currently it sounds like one could define what "mdash" is. Also that the specific Unicode character is used is not really important here.
  9. Timo Poppinga commented on patch set 2 06/23/18, 10:18

    I'm fine with renaming the argument to useNdash, to make it more clear. I do not understand your comment: "Also that the specific Unicode character is used is not really important here". Because of typographic reasons you are only allowed to use the ndash for cutting the 00.
  10. Mathias Brodala commented on patch set 2 06/23/18, 10:26

    > I'm fine with renaming the argument to useNdash, to make it more > clear. I do not understand your comment: "Also that the specific > Unicode character is used is not really important here". Because of > typographic reasons you are only allowed to use the ndash for > cutting the 00. Why suddenly "ndash"? ;-) And yes, there might be reasons for this specific dash but the end user won't care about this detail as long as it is correct. So please neither "mdash" nor "ndash" but simply "dash".
  11. Timo Poppinga uploaded patch set 3 06/23/18, 11:51

  12. Timo Poppinga commented on patch set 2 06/23/18, 11:53

    Reply Unresolved

    Done

    CurrencyViewHelper.php:74 Reply

    Done

    CurrencyViewHelper.php:105 Reply Unresolved

    Done
  13. TYPO3com voted on patch set 3 V +1 06/23/18, 11:59 Completed build in 08m 07s on Sat, 23 Jun, 01:59 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24757

  14. Mathias Brodala commented on patch set 3 06/23/18, 12:13

    Feature-57331-SupportMdashInCurrencyViewHelper.rst:4

    I'd say "dash" here too.

    CurrencyViewHelperTest.php:378

    Can you merge these two with a dataprovider? AFAIS only the value is different.
  15. Timo Poppinga uploaded patch set 4 06/23/18, 12:27

  16. Timo Poppinga commented on patch set 4 CR -1 06/23/18, 12:28

    on it
  17. TYPO3com voted on patch set 4 V +1 06/23/18, 12:36 Completed build in 08m 33s on Sat, 23 Jun, 02:36 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24758

  18. Timo Poppinga uploaded patch set 5 06/23/18, 13:14

  19. TYPO3com voted on patch set 5 V +1 06/23/18, 13:22 Completed build in 08m 13s on Sat, 23 Jun, 03:22 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24763

  20. Marcus Schwemer voted on patch set 5 V +1 CR +1 06/23/18, 14:00

  21. Frans Saris voted on patch set 5 CR +1 06/23/18, 14:14

  22. Susi Moog voted on patch set 5 V +2 CR +2 06/23/18, 14:41

  23. Susi Moog merged patch set 6 06/23/18, 14:41