Review TYPO3_8-7 Abandoned

57338[BUGFIX] Always use a separate Response object within the form context

Georg Großberger CR 0 V 0 Easy +1 −1 updated 07/16/18, 08:09

Commit message

Currently, the instance stored in the rendering context is used, which
is a reference to the same object of the extbase Response object. This
causes the message of the confirmation finisher being displayed twice,
because it is added by the finisher and then appended again by extbase.

This change simply ignores the rendering context response and uses its
own instance.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Georg Großberger uploaded patch set 1 06/23/18, 09:48

  2. TYPO3com voted on patch set 1 V +1 06/23/18, 09:57 Completed build in 09m 25s on Sat, 23 Jun, 11:57 AM Test Summary: 58398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2598

  3. Ralf Zimmermann commented on patch set 1 CR -1 06/25/18, 15:58

  4. Georg Großberger abandoned the change 07/16/18, 08:09