Review TYPO3_8-7 Merged

57351[TASK] Avoid thousands of removeDotsFromTs in TemplatePaths

Jigal van Hemert CR +2 V +2 Easy +7 −14 updated 06/24/18, 21:51

Commit message

This patch avoids calling GeneralUtility::removeDotsFromTs
on the entire TS array, instead selectively calling it only on
the sub-array and only if a sub-array was actually resolved.

In my extremely small testing setup this patch avoids 1,100
calls in FE and 6,000 calls in BE (in page module with fluid
previews being rendered).

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Jigal van Hemert commented on patch set 1 06/23/18, 19:39

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/23/18, 19:53 Completed build in 13m 48s on Sat, 23 Jun, 09:53 PM Test Summary: 58398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2605

  3. Stefan Neufeind commented on patch set 1 V +2 CR +2 06/24/18, 21:51

    same as in master
  4. Stefan Neufeind merged patch set 2 06/24/18, 21:51