57352[FEATURE] Use dragonmantank/cron-expression to calculate cron commands
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/master/Feature-85368-UseDragonmantankcron-expressionToCalculateCronCommand.rstnew+14 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+6 −17
- typo3/sysext/scheduler/Classes/CronCommand/CronCommand.phpdeleted+0 −227
- typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.phpdeleted+0 −363
- typo3/sysext/scheduler/Classes/Execution.php+4 −4
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/scheduler/Tests/Unit/CronCommand/AccessibleProxies/NormalizeCommandAccessibleProxy.phpdeleted+0 −73
- typo3/sysext/scheduler/Tests/Unit/CronCommand/CronCommandTest.phpdeleted+0 −337
- typo3/sysext/scheduler/Tests/Unit/CronCommand/NormalizeCommandTest.phpdeleted+0 −663
- composer.json+1 −0
- composer.lock+51 −2
Review log 1317
-
Georg Ringer uploaded patch set 1 06/23/18, 19:49
-
TYPO3com voted on patch set 1 V -1 06/23/18, 19:49 Completed build in 09s on Sat, 23 Jun, 09:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24795
-
Georg Ringer uploaded patch set 2 06/23/18, 19:51
-
TYPO3com voted on patch set 2 V -1 06/23/18, 20:00 Completed build in 08m 44s on Sat, 23 Jun, 10:00 PM Test Summary: 147 of 32260 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24796
-
Georg Ringer uploaded patch set 3 06/23/18, 20:11
-
TYPO3com voted on patch set 3 V +1 06/23/18, 20:21 Completed build in 09m 40s on Sat, 23 Jun, 10:21 PM Test Summary: 31865 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24798
-
Mathias Brodala commented on patch set 3 CR -1 06/25/18, 07:27
Please add a RST. Als mention that we now support "@<frequency>" values like "@monthly". -
Georg Ringer commented on patch set 3 06/25/18, 09:02
@monthly was already supported ;) -
Mathias Brodala commented on patch set 3 06/25/18, 09:11
> @monthly was already supported ;) Great, it's been a long time since I've tried. ;-) -
Anja Leichsenring commented on patch set 3 08/10/18, 17:07
> Patch Set 3: > > > @monthly was already supported ;) > > Great, it's been a long time since I've tried. ;-) ping? still blocked - why? Can we continue? -
Mathias Brodala commented on patch set 3 08/13/18, 08:25
> > Patch Set 3: > > > > > @monthly was already supported ;) > > > > Great, it's been a long time since I've tried. ;-) > > ping? still blocked - why? Can we continue? Yes, since it's still a feature it still needs an RST. ;-) -
Jan Helke uploaded patch set 4 08/17/18, 13:04
-
Jan Helke voted on patch set 4 V +1 CR +1 08/17/18, 13:08
-
TYPO3com voted on patch set 4 V +1 08/17/18, 13:14 Completed build in 10m 24s on Fri, 17 Aug, 03:14 PM Test Summary: 34015 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26742
-
Christian Kuhn voted on patch set 4 CR -2 08/17/18, 15:31
-
Christian Kuhn commented on patch set 4 08/17/18, 15:35
this looks way too sparse to me: how are errors handled? are error messages localized? also absolutely all tests are removed. while i agree that details should (hopefully?) be rendered by the library, we don't even have a basic coverage of the most trivial things anymore. apart from that, our implementation handles details like summper / wintertime switches. Is that true for the library, too? Could you elaborate a bit on that, please? And in general: Our implementation did not show a single bug since its rewrite 4.3, do you know anything it can't do? Stuff like @monthly is in place since ever. What is better with the library that should convince us to add it as additional dependency we need to maintain instead of own code that entirely (to my knowledge) solved the issue since ~8 years? -
Georg Ringer abandoned the change 08/31/18, 20:12
abandoned, thanks lolly for your helpfull comments