Review main Merged

57358[BUGFIX] Check for exceptions instead of number of affected rows

Georg Ringer CR +2 V +2 Easy +13 −8 updated 07/06/18, 19:00

Commit message

Saving a scheduler task without any changes leads to 0 affected
rows which must not be interpreted as an error.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Frans Saris +1
    • Rudy Gnodde +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Rudy Gnodde +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 06/24/18, 16:27

  2. Wouter Wolters voted on patch set 1 CR +1 06/24/18, 16:28

  3. TYPO3com voted on patch set 1 V +1 06/24/18, 16:35 Completed build in 08m 05s on Sun, 24 Jun, 06:35 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24817

  4. Frans Saris voted on patch set 1 CR +1 06/24/18, 17:13

  5. Stefan Neufeind voted on patch set 1 V +1 CR +1 06/24/18, 21:49

  6. Rudy Gnodde voted on patch set 1 V +1 CR +1 07/06/18, 14:14

  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 07/06/18, 19:00

  8. Anja Leichsenring merged patch set 2 07/06/18, 19:00

  9. Anja Leichsenring commented on patch set 2 07/06/18, 19:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 421fa92ab03f705b5dcc88a93a878e21acd322ca