Review main Merged

57379[TASK] Deprecate TYPO3\CMS\Core\Database\PdoHelper

Christian Kuhn CR +2 V +2 Normal +68 −2 updated 06/26/18, 19:25

Commit message

The PdoHelper class with its single method importSql() has
been added for the Pdo cache backend which is also still
the only usage of that helper class.
With the migration to doctrine, that class feels misplaced
and obsolete. The code is moved over as protected method
into Pdo cache backend directly and the PdoHelper class
is marked as deprecated.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Benni Mack +1
  • Verified V +2
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Christian Kuhn uploaded patch set 1 06/26/18, 18:00

  2. TYPO3com voted on patch set 1 V +1 06/26/18, 18:08 Completed build in 08m 09s on Tue, 26 Jun, 08:08 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24882

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/26/18, 18:40

  4. Frank Nägler voted on patch set 1 V +2 CR +2 06/26/18, 19:25

  5. Frank Nägler merged patch set 2 06/26/18, 19:25