Review main Merged

57381[TASK] Move csh handling to backend extension

Christian Kuhn CR +2 V +2 Hard +192 −274 updated 06/26/18, 20:11

Commit message

The core and documentation team decided to drop the inline
manual view from core for various reasons that will be further
outlined with a second patch.

The documentation extension currently does both the manual
display, and also the "csh" rendering. The latter has been
merged from ext:cshmanual into ext:documentation quite
recently with core version v9.0.

The patch extracts this csh handling from ext:documentation
again and puts it into ext:backend. The patch is similar to
the v9.0 patch, only slight additions are applied along the way.
This changes also unmarks the documentation extension from
"partOfMinimalUsableSystem" since the direct dependency of
ext:backend to ext:documentation is gone with the csh merge
into backend extension.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 30

Show 10 more files

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/26/18, 19:20

  2. TYPO3com voted on patch set 1 V +1 06/26/18, 19:27 Completed build in 07m 52s on Tue, 26 Jun, 09:27 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24885

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/26/18, 19:28

  4. Wouter Wolters voted on patch set 1 CR +1 06/26/18, 19:38

  5. Frank Nägler voted on patch set 1 V +2 CR +2 06/26/18, 20:11

  6. Frank Nägler merged patch set 2 06/26/18, 20:11