57384[BUGFIX] Use correct type for getSections $mode parameter comment
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jörg Bösche +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Tymoteusz Motylewski uploaded patch set 1 06/26/18, 20:40
-
TYPO3com voted on patch set 1 V +1 06/26/18, 20:48 Completed build in 08m 26s on Tue, 26 Jun, 10:48 PM Test Summary: 32729 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24896
-
Jörg Bösche commented on patch set 1 CR -1 06/26/18, 20:52
-
Tymoteusz Motylewski commented on patch set 1 06/26/18, 21:11
TableManualRepository.php:82Replythis would be breaking, as this is an old code. -
Jörg Bösche commented on patch set 1 06/26/18, 21:14
Breaking because of usages / extended usage in 3rd party extensions? This patch is only for the new v9. In my opinion, this is a good step to dive into code quality and type safe methods in our core. -
Tymoteusz Motylewski commented on patch set 1 06/28/18, 20:13
Hi Joerg, We strive for not introducing new breaking changes after 9.0 release. Additionaly, the rule of thumb is that we enforce strong typing for new code. Existing code is not changed if it doesnt have to be changed -
Jörg Bösche commented on patch set 1 CR +1 06/28/18, 20:52
Removed -1, due to the argument of Tymoteusz. -
Andreas Kienast voted on patch set 1 V +1 CR +1 06/29/18, 08:27
-
Christian Kuhn voted on patch set 1 V +2 CR +2 07/02/18, 19:32
-
Christian Kuhn merged patch set 2 07/02/18, 19:32
TableManualRepository.php:82