Review main Merged

57387[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again

Frédéric Lebel CR +2 V +2 Easy +0 −8 updated 07/02/18, 10:18

Commit message

Fix the link browser to not drop the CSS-Class value with multiple classes
if editing the same link.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Frédéric Lebel uploaded patch set 1 06/27/18, 03:26

  2. TYPO3com voted on patch set 1 V +1 06/27/18, 03:34 Completed build in 07m 39s on Wed, 27 Jun, 05:34 AM Test Summary: 32750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24900

  3. Jörg Bösche voted on patch set 1 CR +1 06/27/18, 06:30

  4. Markus Klein commented on patch set 1 06/27/18, 06:33

    Did you test your patch also with classes requiring multiple classes? Like with bootstrap "btn btn-primary". This used to work, so this should keep working.
  5. Frédéric Lebel commented on patch set 1 06/28/18, 13:31

    I did not find any documentation with classes requiring multiples classes in the ckeditor documentation. On the other hand, there is something in that of rtehtmlarea that has not been put in that of ckeditor.
  6. Benni Mack voted on patch set 1 V +1 CR +2 07/02/18, 07:54

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 07/02/18, 10:18

  8. Christian Kuhn merged patch set 2 07/02/18, 10:18

  9. Christian Kuhn commented on patch set 2 07/02/18, 10:18

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit fac4777cf11a3aff6f3b89ab30e1e8401a6b56f6