Review main Merged

57391[TASK] Migrate "GFX/processor_effects" to boolean

Mathias Brodala CR +2 V +2 Normal +82 −18 updated 06/28/18, 17:51

Commit message

Ensure "GFX/processor_effects" is a true boolean as suggested in
the settings module and silently migrate integer/string values
accordingly.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frans Saris +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1620

  1. Mathias Brodala uploaded patch set 1 06/27/18, 07:28

  2. Benni Mack commented on patch set 1 CR -1 06/27/18, 07:33

    The option should actually be changed to be a true boolean value btw. and... the commit message could be a bit more descriptive. ;)
  3. TYPO3com voted on patch set 1 V -1 06/27/18, 07:36 Completed build in 08m 23s on Wed, 27 Jun, 09:36 AM Test Summary: 6 of 32998 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24908

  4. Mathias Brodala uploaded patch set 2 06/27/18, 08:06

  5. Mathias Brodala commented on patch set 2 06/27/18, 08:07

    > The option should actually be changed to be a true boolean value > btw. Possibly, but that's something for a different change. ;-)
  6. TYPO3com voted on patch set 2 V +1 06/27/18, 08:17 Completed build in 10m 41s on Wed, 27 Jun, 10:17 AM Test Summary: 32750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24914

  7. Mathias Brodala commented on patch set 2 CR -1 06/27/18, 08:50

    Still on it, this whole topic needs a bit more work.
  8. Mathias Brodala uploaded patch set 3 06/27/18, 11:54

  9. TYPO3com voted on patch set 3 V +1 06/27/18, 12:03 Completed build in 08m 47s on Wed, 27 Jun, 02:03 PM Test Summary: 32867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24929

  10. Benni Mack commented on patch set 3 CR -1 06/27/18, 12:47

    Although this fixes one important thing in master (= ensuring that it's a bool) for 8.7 we need to keep the integers.
  11. Mathias Brodala updated the commit message in patch set 4 06/27/18, 13:04

  12. Benni Mack voted on patch set 4 CR +1 06/27/18, 13:09

  13. TYPO3com voted on patch set 4 V +1 06/27/18, 13:13 Completed build in 08m 35s on Wed, 27 Jun, 03:13 PM Test Summary: 32867 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24933

  14. Markus Klein commented on patch set 4 06/27/18, 13:29

    SilentConfigurationUpgradeServiceTest.php:586

    false?
  15. Mathias Brodala commented on patch set 4 06/27/18, 13:31

    SilentConfigurationUpgradeServiceTest.php:586 Reply

    Anything is fine here actually since the value is not evaluated anyways, as long as "GFX/processor" is empty.
  16. Markus Klein voted on patch set 4 CR +1 06/27/18, 13:34

  17. Benni Mack voted on patch set 4 V +1 06/28/18, 13:55

  18. Frans Saris voted on patch set 4 CR +1 06/28/18, 17:12

  19. Markus Klein voted on patch set 4 V +2 CR +2 06/28/18, 17:51

  20. Markus Klein merged patch set 5 06/28/18, 17:51