Review main Merged

57393[BUGFIX] Ensure extension icon exists before calling ImageInfo

Nicole Hummel CR +2 V +2 Easy +8 −3 updated 06/28/18, 19:42

Commit message

As the extension icon is not required, this patch prevents warnings
that are triggered because no image size can be fetched.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2
    • Nicole Hummel +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Nicole Hummel uploaded patch set 1 06/27/18, 10:08

  2. TYPO3com voted on patch set 1 V +1 06/27/18, 10:16 Completed build in 07m 57s on Wed, 27 Jun, 12:16 PM Test Summary: 32750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24923

  3. Georg Ringer voted on patch set 1 V +1 CR +1 06/27/18, 11:58

  4. Oliver Hader voted on patch set 1 CR +1 06/28/18, 16:27

  5. Wouter Wolters voted on patch set 1 CR +1 06/28/18, 18:53

  6. Nicole Hummel voted on patch set 1 V +2 CR +2 06/28/18, 19:09

  7. Nicole Hummel merged patch set 2 06/28/18, 19:09

  8. Wouter Wolters commented on patch set 2 06/28/18, 19:42

    a verified vote was missing here Nicole ;-)