Review main Abandoned

57394[TASK] Add "datetimesec" eval option for input renderType inputDate

TYPO3com CR 0 V 0 Easy +34 −1 updated 11/08/18, 20:10

Commit message

Full time including seconds in backend for specific input-fields,
e.g. in custom log-singletons/domain-models, without setting
$GLOBALS['TYPO3_CONF_VARS']['SYS']['hhmm'] to 'h:i:s' generally.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 47

  1. TYPO3com uploaded patch set 1 06/27/18, 12:54

  2. TYPO3com voted on patch set 1 V -1 06/27/18, 12:54 Completed build in 07s on Wed, 27 Jun, 02:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24932

  3. Oliver Kleinecke wrote 06/28/18, 11:11

    Removed reviewer Oliver Kleinecke.
  4. Jörg Bösche commented on patch set 2 09/14/18, 12:22

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 09/14/18, 12:31 Completed build in 08m 18s on Fri, 14 Sep, 02:31 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28089

  6. Guido Schmechel commented on patch set 2 V -1 CR -1 09/22/18, 19:43

    - More Tests - datetimesec (InputDateTimeElement Line 140) - ":s" options show AM and PM option in the DatePicker
  7. Benni Mack abandoned the change 11/08/18, 20:10

    abandoned. this is a feature, and we'd need to have a migration wizard etc. I'll leave the issue open so we can check that once feature freeze is lifted again.