Review main Merged

57399[BUGFIX] Use 403 header instead of 401 header

Markus Klein CR +2 V +2 Easy +7 −10 updated 09/10/18, 07:53

Commit message

The usage of a 401 header must be accompanied by a valid
www-authenticate header, which does not support form-based logins.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1517

  1. Markus Klein uploaded patch set 1 06/27/18, 17:00

  2. TYPO3com voted on patch set 1 V +1 06/27/18, 17:08 Completed build in 08m 25s on Wed, 27 Jun, 07:08 PM Test Summary: 32849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24941

  3. Mathias Brodala commented on patch set 1 CR -1 06/28/18, 07:23

    What about our UnauthorizedException? Shouldn't it be changed to require the www-authenticate header? (This would be breaking of course.)

    RequestHandler.php:170

    This needs a change also in Resources/Public/JavaScript/Modules/Router.js AFAIS.
  4. Markus Klein commented on patch set 1 06/28/18, 09:52

    Oh I overlooked that exception. We should change it to 403 too.

    RequestHandler.php:170 Reply

    ah, I didn't check our JS so far. Thanks.
  5. Markus Klein commented on patch set 1 06/28/18, 09:53

    hm... nope UnauthorizedException can't be changed we have forbiddenexception too. It's not used in Core currently, so it doesn't matter too much.
  6. Markus Klein commented on patch set 1 07/15/18, 22:11

    @Mathias Please reconsider your -1. Thanks
  7. Mathias Brodala commented on patch set 1 07/16/18, 07:23

    RequestHandler.php:170 Reply

    What about this?
  8. Markus Klein uploaded patch set 2 07/17/18, 22:14

  9. TYPO3com voted on patch set 2 V +1 07/17/18, 22:22 Completed build in 07m 41s on Wed, 18 Jul, 12:22 AM Test Summary: 33357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25510

  10. Wouter Wolters voted on patch set 2 CR +1 07/18/18, 20:54

  11. Daniel Goerz voted on patch set 2 CR +1 07/19/18, 15:48

  12. Benni Mack voted on patch set 2 CR +2 09/04/18, 06:45

  13. Benni Mack voted on patch set 2 V +1 09/04/18, 10:02

  14. Markus Klein wrote 09/09/18, 20:50

    Removed reviewer Markus Poerschke.
  15. Christian Kuhn voted on patch set 2 V +1 CR +1 09/10/18, 07:36

  16. Markus Klein voted on patch set 2 V +2 09/10/18, 07:53

  17. Markus Klein merged patch set 3 09/10/18, 07:53