57399[BUGFIX] Use 403 header instead of 401 header
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Daniel Goerz +1
- Wouter Wolters +1
- Christian Kuhn +1
-
Verified V +2
- Markus Klein +2
- Christian Kuhn +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Configuration/SiteConfiguration/site_errorhandling.php+0 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration_tca.xlf+0 −3
- typo3/sysext/core/Classes/Resource/Hook/FileDumpEIDHookInterface.php+2 −1
- typo3/sysext/core/Documentation/Changelog/9.2/Feature-84581-SiteHandling.rst+3 −3
- typo3/sysext/install/Classes/Http/RequestHandler.php3+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js+1 −1
Review log 1517
-
Markus Klein uploaded patch set 1 06/27/18, 17:00
-
TYPO3com voted on patch set 1 V +1 06/27/18, 17:08 Completed build in 08m 25s on Wed, 27 Jun, 07:08 PM Test Summary: 32849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24941
-
Mathias Brodala commented on patch set 1 CR -1 06/28/18, 07:23
What about our UnauthorizedException? Shouldn't it be changed to require the www-authenticate header? (This would be breaking of course.)RequestHandler.php:170This needs a change also in Resources/Public/JavaScript/Modules/Router.js AFAIS. -
Markus Klein commented on patch set 1 06/28/18, 09:52
Oh I overlooked that exception. We should change it to 403 too.RequestHandler.php:170Replyah, I didn't check our JS so far. Thanks. -
Markus Klein commented on patch set 1 06/28/18, 09:53
hm... nope UnauthorizedException can't be changed we have forbiddenexception too. It's not used in Core currently, so it doesn't matter too much. -
Markus Klein commented on patch set 1 07/15/18, 22:11
@Mathias Please reconsider your -1. Thanks -
Mathias Brodala commented on patch set 1 07/16/18, 07:23
RequestHandler.php:170ReplyWhat about this? -
Markus Klein uploaded patch set 2 07/17/18, 22:14
-
TYPO3com voted on patch set 2 V +1 07/17/18, 22:22 Completed build in 07m 41s on Wed, 18 Jul, 12:22 AM Test Summary: 33357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25510
-
Wouter Wolters voted on patch set 2 CR +1 07/18/18, 20:54
-
Daniel Goerz voted on patch set 2 CR +1 07/19/18, 15:48
-
Benni Mack voted on patch set 2 CR +2 09/04/18, 06:45
-
Benni Mack voted on patch set 2 V +1 09/04/18, 10:02
-
Markus Klein wrote 09/09/18, 20:50
Removed reviewer Markus Poerschke. -
Christian Kuhn voted on patch set 2 V +1 CR +1 09/10/18, 07:36
-
Markus Klein voted on patch set 2 V +2 09/10/18, 07:53
-
Markus Klein merged patch set 3 09/10/18, 07:53