57403[TASK] Decouple TemplateService->getFileName
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Anja Leichsenring +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+25 −39
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85445-TemplateService-getFileName.rst1new+37 −0
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+1 −35
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/TemplateServiceTest.phpnew+75 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+11 −5
- typo3/sysext/frontend/Classes/ContentObject/FileContentObject.php+19 −14
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −2
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php1+7 −2
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+71 −16
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php4new+107 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+12 −18
- typo3/sysext/frontend/Tests/Unit/Resource/FilePathSanitizerTest.phpnew+67 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+10 −5
Review log 2030
Show 45 earlier messages
-
Benni Mack uploaded patch set 1 06/28/18, 07:24
-
Mathias Brodala commented on patch set 1 06/28/18, 07:30
-
TYPO3com voted on patch set 1 V -1 06/28/18, 07:32 Completed build in 08m 26s on Thu, 28 Jun, 09:32 AM Test Summary: 12 of 33103 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24951
-
Patrick Schriner commented on patch set 1 06/28/18, 08:37
This will have side effects on "fake frontends" if it will be impossible to manipulate allowedPaths (a bit abusive) as it is a singleton. It shouldn't use hard coded path segmements which could be resolved using the Environment class (see #85286) -
Benni Mack uploaded patch set 2 06/28/18, 17:40
-
TYPO3com voted on patch set 2 V -1 06/28/18, 17:56 Completed build in 15m 05s on Thu, 28 Jun, 07:56 PM Test Summary: 7 of 33095 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24966
-
Benni Mack uploaded patch set 3 07/01/18, 15:55
-
TYPO3com voted on patch set 3 V -1 07/01/18, 16:03 Completed build in 07m 34s on Sun, 1 Jul, 06:03 PM Test Summary: 10 of 33125 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25000
-
Benni Mack uploaded patch set 4 07/01/18, 16:09
-
TYPO3com voted on patch set 4 V -1 07/01/18, 16:18 Completed build in 08m 27s on Sun, 1 Jul, 06:18 PM Test Summary: 7 of 33125 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25001
-
Benni Mack uploaded patch set 5 07/01/18, 16:20
-
TYPO3com voted on patch set 5 V -1 07/01/18, 16:28 Completed build in 08m 26s on Sun, 1 Jul, 06:28 PM Test Summary: 4 of 33126 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25003
-
Benni Mack uploaded patch set 6 07/01/18, 16:33
-
TYPO3com voted on patch set 6 V +1 07/01/18, 16:41 Completed build in 08m 11s on Sun, 1 Jul, 06:41 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25004
-
Benni Mack commented on patch set 7 07/01/18, 16:43
Published edit on patch set 6. -
TYPO3com voted on patch set 7 V -1 07/01/18, 16:50 Completed build in 07m 42s on Sun, 1 Jul, 06:50 PM Test Summary: 1 of 33126 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25005
-
TYPO3com voted on patch set 7 V +1 07/01/18, 17:01 Completed build in 26m 26s on Sun, 1 Jul, 07:01 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25005
-
Wouter Wolters commented on patch set 7 07/01/18, 17:16
Deprecation-85445-TemplateService-getFileName.rst:16acted asGifBuilder.php:679string|nullFilePathSanitizer.php:32This are the -
Frans Saris commented on patch set 7 07/01/18, 19:41
FilePathSanitizer.php:66IMO sanitize is the wrong name here. It tries to resolve a path and validates it when relative. If it could be parsed as a absolute url then there isn't any sanitizing at all. Think a better name would be `resolve()` -
Björn Jacob commented on patch set 7 07/01/18, 20:33
"validates"FilePathSanitizer.php:32Reply"These" instead of "This" -
Benni Mack uploaded patch set 8 07/02/18, 07:03
-
Benni Mack commented on patch set 7 07/02/18, 07:06
FilePathSanitizer.php:66Reply Unresolvedhmm, I think resolve() is generic, and is used too much throughout the core. The main thing that is resolving is `EXT:...` syntax, the other is actually checking if everything matches. Sanitizing came from the idea of returning a "clean" string. Now it throws an exception if something is wrong. tbh, I don't care too much on the name here, whatever the majority decides on, I will adapt the patch. -
TYPO3com voted on patch set 8 V +1 07/02/18, 07:12 Completed build in 08m 32s on Mon, 2 Jul, 09:12 AM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25009
-
Christian Kuhn commented on patch set 8 CR -1 07/02/18, 09:21
on it. -
Christian Kuhn uploaded patch set 9 07/02/18, 10:14
-
Christian Kuhn commented on patch set 9 V +1 CR +1 07/02/18, 10:14
changed only minor things. -
TYPO3com voted on patch set 9 V +1 07/02/18, 10:22 Completed build in 08m 17s on Mon, 2 Jul, 12:22 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25018
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 07/02/18, 10:29
-
Benni Mack voted on patch set 9 V +2 CR +2 07/02/18, 10:48
-
Benni Mack merged patch set 10 07/02/18, 10:48
ResourceSanitizer.php:30