Review main Merged

57404[BUGFIX] Separate icon and text in inline record control buttons

Mathias Brodala CR +2 V +2 Easy +1 −1 updated 06/28/18, 13:04

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Mathias Brodala uploaded patch set 1 06/28/18, 09:48

  2. TYPO3com voted on patch set 1 V +1 06/28/18, 09:57 Completed build in 09m 43s on Thu, 28 Jun, 11:57 AM Test Summary: 32855 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24956

  3. Björn Jacob voted on patch set 1 V +1 CR +1 06/28/18, 10:11

  4. Tymoteusz Motylewski commented on patch set 1 06/28/18, 12:39

    How can I repreduce it? I checked some inline relations, but I see different icons, and they look good without the patch.
  5. Christian Kuhn commented on patch set 1 06/28/18, 12:57

    @tymek added a zoomed before-after.png to issue to show the difference.
  6. Christian Kuhn voted on patch set 1 V +1 CR +1 06/28/18, 12:58

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 06/28/18, 13:04

  8. Christian Kuhn merged patch set 2 06/28/18, 13:04

  9. Christian Kuhn commented on patch set 2 06/28/18, 13:04

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 50f660760d480b8674490e3608e01080c25ad409