Review main Abandoned

57405[TASK] Take itemsProcFunc into account when rendering DB-List-Rows

TYPO3com CR 0 V 0 Easy +26 −5 updated 11/08/18, 20:07

Commit message

[IMPORTANT!!!!!] : db-recordlists should take custom itemsProcFunc into
account when rendering list-row-values

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 918

  1. TYPO3com uploaded patch set 1 06/28/18, 10:06

  2. TYPO3com voted on patch set 1 V -1 06/28/18, 10:06 Completed build in 08s on Thu, 28 Jun, 12:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24957

  3. Oliver Kleinecke commented on patch set 2 07/02/18, 12:32

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 07/02/18, 12:32 Completed build in 09s on Mon, 2 Jul, 02:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25032

  5. Oliver Kleinecke commented on patch set 3 07/02/18, 12:35

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V -1 07/02/18, 12:35 Completed build in 08s on Mon, 2 Jul, 02:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25033

  7. Oliver Kleinecke commented on patch set 4 07/02/18, 12:41

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V -1 07/02/18, 12:42 Completed build in 07s on Mon, 2 Jul, 02:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25034

  9. Oliver Kleinecke commented on patch set 5 07/02/18, 12:49

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V -1 07/02/18, 12:49 Completed build in 10s on Mon, 2 Jul, 02:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25035

  11. Oliver Kleinecke commented on patch set 6 07/02/18, 12:59

    Published edit on patch set 5.
  12. TYPO3com voted on patch set 6 V -1 07/02/18, 12:59 Completed build in 08s on Mon, 2 Jul, 02:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25036

  13. Mathias Schreiber uploaded patch set 7 07/02/18, 13:16

  14. TYPO3com voted on patch set 7 V +1 07/02/18, 13:28 Completed build in 11m 16s on Mon, 2 Jul, 03:28 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25040

  15. Oliver Kleinecke commented on patch set 8 07/03/18, 06:32

    Published edit on patch set 7.
  16. TYPO3com voted on patch set 8 V +1 07/03/18, 06:40 Completed build in 08m 01s on Tue, 3 Jul, 08:40 AM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25053

  17. Tymoteusz Motylewski commented on patch set 8 CR -1 07/05/18, 09:38

    DatabaseRecordList.php:1507

    In other places in the core, there is already a handling for itemsProcFunction done. In some places it uses GeneralUtility::callUserFunction(, In others there are helper methods like resolveItemProcessorFunction getProcessingItems. I'm not an expert in this area, but I'm pretty certain this code should be refactored.
  18. Benni Mack abandoned the change 11/08/18, 20:07

    I agree this probably needs a different approach. We've come quite far with the DB list functionality for now, but we should target this for v10 - using itemsProcFunc would add the need for actually also using pageTSconfig and so on - this will slow down the performance of the list (each record, each field) drastically, so we'll need some more logic. I will keep the issue open so we can brainstorm on how this could look like. Thanks for your efforts so far, Oliver.