Review main Merged

57409[BUGFIX] Display documentation changelog files with same issue number

Anja Leichsenring CR +2 V +2 Easy +13 −14 updated 07/02/18, 12:24

Commit message

By using a hash instead of the issue number as array key, no file gets
lost any longer due to collision. Same issue numbers for documentation
files are quite common, e.g. when a new feature deprecates replaced code.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Anja Leichsenring uploaded patch set 1 06/28/18, 16:47

  2. Anja Leichsenring uploaded patch set 2 06/28/18, 16:49

  3. TYPO3com voted on patch set 2 V +1 06/28/18, 16:59 Completed build in 10m 46s on Thu, 28 Jun, 07:00 PM Test Summary: 32858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24963

  4. TYPO3com voted on patch set 1 V +1 06/28/18, 17:01 Completed build in 13m 33s on Thu, 28 Jun, 07:01 PM Test Summary: 32858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24962

  5. Anja Leichsenring updated the commit message in patch set 3 06/28/18, 17:17

  6. TYPO3com voted on patch set 3 V +1 06/28/18, 17:30 Completed build in 13m 08s on Thu, 28 Jun, 07:30 PM Test Summary: 32858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24964

  7. Wouter Wolters voted on patch set 3 CR +1 06/28/18, 18:51

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 07/02/18, 12:21

  9. Christian Kuhn commented on patch set 3 V +1 CR +1 07/02/18, 12:22

    checked the missing files are now displayed in master and the extension scanner still can mark the fully scanned files as not affected. files with same issue id are now properly displayed.
  10. Christian Kuhn voted on patch set 3 V +2 CR +2 07/02/18, 12:23

  11. Christian Kuhn merged patch set 4 07/02/18, 12:23

  12. Christian Kuhn commented on patch set 4 07/02/18, 12:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5646b239b1862a298a222d2840f90753ac9f83c9