Review TYPO3_8-7 Merged

57415[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer

Stefan Neufeind CR +2 V +2 Normal +126 −38 updated 06/30/18, 06:33

Commit message

This patch moves the logic from the render method of the
YouTube and Vimeo Renderer to dedicated methods to keep
the render methods themselves as short, clean and simple as
possible.

Also $options is initialized as an empty array as stated
in the interface.

Functionality, Output and Behavior stay unchanged.

Review

  • Code review CR +2
    • Frans Saris +2
    • Daniel Goerz +1
  • Verified V +2
    • Frans Saris +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Stefan Neufeind uploaded patch set 1 06/29/18, 06:55

  2. TYPO3com voted on patch set 1 V -1 06/29/18, 06:56 Completed build in 06s on Fri, 29 Jun, 08:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2637

  3. Stefan Neufeind uploaded patch set 2 06/29/18, 06:57

  4. Stefan Neufeind commented on patch set 2 06/29/18, 06:59

    Hand-picked from master. Please check!
  5. TYPO3com voted on patch set 2 V +1 06/29/18, 07:09 Completed build in 11m 40s on Fri, 29 Jun, 09:09 AM Test Summary: 58398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2638

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 06/29/18, 08:08

  7. Daniel Goerz commented on patch set 2 06/29/18, 08:09

    Maybe merge the backport of https://review.typo3.org/#/c/57325/ first
  8. Daniel Goerz commented on patch set 2 V 0 CR 0 06/29/18, 08:12

    > Maybe merge the backport of https://review.typo3.org/#/c/57325/ > first The changes of the linked patch are already included here, so either merge the linked patch first or abandon it as it is included here.
  9. Stefan Neufeind commented on patch set 2 CR -1 06/29/18, 08:20

    I've submitted the backport in the other patch now and will redo this patch here. Thanks for the reminder.
  10. Stefan Neufeind uploaded patch set 3 06/29/18, 08:36

  11. TYPO3com voted on patch set 3 V +1 06/29/18, 08:44 Completed build in 08m 17s on Fri, 29 Jun, 10:44 AM Test Summary: 58422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2642

  12. Daniel Goerz voted on patch set 3 V +1 CR +1 06/29/18, 08:46

  13. Frans Saris voted on patch set 3 V +2 CR +2 06/30/18, 06:33

  14. Frans Saris merged patch set 4 06/30/18, 06:33