Review main Merged

57417[BUGFIX] Allow overlay for all root level records

Mathias Brodala CR +2 V +2 Normal +67 −75 updated 10/30/18, 20:23

Commit message

Instead of a hardcoded list of tables allowed on root level use
the information from TCA instead.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1823

  1. Mathias Brodala uploaded patch set 1 06/29/18, 09:25

  2. Mathias Brodala uploaded patch set 2 06/29/18, 09:28

  3. TYPO3com voted on patch set 2 V +1 06/29/18, 09:38 Completed build in 09m 33s on Fri, 29 Jun, 11:38 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24979

  4. TYPO3com voted on patch set 1 V +1 06/29/18, 09:39 Completed build in 13m 52s on Fri, 29 Jun, 11:39 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24978

  5. Mathias Brodala commented on patch set 3 06/29/18, 09:42

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 06/29/18, 09:57 Completed build in 15m 29s on Fri, 29 Jun, 11:57 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24980

  7. Tymoteusz Motylewski commented on patch set 3 06/29/18, 10:56

    PageRepository.php:585

    why this comment was removed?
  8. Mathias Brodala commented on patch set 3 06/29/18, 11:10

    PageRepository.php:585 Reply

    Because it sounded to me like it is resolved now.
  9. Benni Mack commented on patch set 3 10/28/18, 12:18

    Hi Mathias, can you provide a real-life example where you want to use this?
  10. Benni Mack commented on patch set 3 10/29/18, 16:28

    PageRepository.php:585 Reply

    it is resolved. with pages_language_overlay gone in v9 (and the overlays in different tables gone in v8), we're safe.
  11. Mathias Brodala commented on patch set 3 10/30/18, 08:06

    > Hi Mathias, can you provide a real-life example where you want to > use this? Sure, we where in need for this when we started to use https://bitbucket.typo3.com/projects/EXT/repos/file_variants. I can imagine there are more 3rd party extensions which would also benefit from this change.
  12. Benni Mack updated the commit message in patch set 4 10/30/18, 11:15

  13. Benni Mack voted on patch set 4 CR +1 10/30/18, 11:15

  14. Benni Mack commented on patch set 4 CR -1 10/30/18, 11:16

    PageRepository.php:580

    btw... this does not work btw if people have 'rootLevel' = 1 'rootLevel' => '1' etc.
  15. Benni Mack commented on patch set 5 10/30/18, 11:17

    Published edit on patch set 4.
  16. Benni Mack voted on patch set 5 V +1 CR +1 10/30/18, 11:17

  17. Mathias Brodala commented on patch set 5 10/30/18, 11:19

    PageRepository.php:580

    Didn't you mean to use "false" here to have "1" also matched?
  18. Benni Mack commented on patch set 5 10/30/18, 11:21

    "1" is fine, could be added separately in the TCA migration

    PageRepository.php:580 Reply

    I rechecked with "sys_file_metadata" and it had 1 as integer, so this was important to be non-breaking, so we're OK as it is.
  19. Mathias Brodala commented on patch set 5 10/30/18, 11:27

    PageRepository.php:580 Reply

    Alright, thanks for checking.
  20. TYPO3com voted on patch set 4 V +1 10/30/18, 11:28 Completed build in 12m 47s on Tue, 30 Oct, 12:28 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29873

  21. TYPO3com voted on patch set 5 V +1 10/30/18, 11:33 Completed build in 14m 10s on Tue, 30 Oct, 12:33 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29874

  22. Wouter Wolters voted on patch set 5 V +2 CR +2 10/30/18, 20:23

  23. Wouter Wolters merged patch set 6 10/30/18, 20:23