57417[BUGFIX] Allow overlay for all root level records
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Benni Mack +1
-
Verified V +2
- Wouter Wolters +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1823
-
Mathias Brodala uploaded patch set 1 06/29/18, 09:25
-
Mathias Brodala uploaded patch set 2 06/29/18, 09:28
-
TYPO3com voted on patch set 2 V +1 06/29/18, 09:38 Completed build in 09m 33s on Fri, 29 Jun, 11:38 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24979
-
TYPO3com voted on patch set 1 V +1 06/29/18, 09:39 Completed build in 13m 52s on Fri, 29 Jun, 11:39 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24978
-
Mathias Brodala commented on patch set 3 06/29/18, 09:42
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 06/29/18, 09:57 Completed build in 15m 29s on Fri, 29 Jun, 11:57 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24980
-
Tymoteusz Motylewski commented on patch set 3 06/29/18, 10:56
PageRepository.php:585why this comment was removed? -
Mathias Brodala commented on patch set 3 06/29/18, 11:10
PageRepository.php:585ReplyBecause it sounded to me like it is resolved now. -
Benni Mack commented on patch set 3 10/28/18, 12:18
Hi Mathias, can you provide a real-life example where you want to use this? -
Benni Mack commented on patch set 3 10/29/18, 16:28
PageRepository.php:585Replyit is resolved. with pages_language_overlay gone in v9 (and the overlays in different tables gone in v8), we're safe. -
Mathias Brodala commented on patch set 3 10/30/18, 08:06
> Hi Mathias, can you provide a real-life example where you want to > use this? Sure, we where in need for this when we started to use https://bitbucket.typo3.com/projects/EXT/repos/file_variants. I can imagine there are more 3rd party extensions which would also benefit from this change. -
Benni Mack updated the commit message in patch set 4 10/30/18, 11:15
-
Benni Mack voted on patch set 4 CR +1 10/30/18, 11:15
-
Benni Mack commented on patch set 4 CR -1 10/30/18, 11:16
PageRepository.php:580btw... this does not work btw if people have 'rootLevel' = 1 'rootLevel' => '1' etc. -
Benni Mack commented on patch set 5 10/30/18, 11:17
Published edit on patch set 4. -
Benni Mack voted on patch set 5 V +1 CR +1 10/30/18, 11:17
-
Mathias Brodala commented on patch set 5 10/30/18, 11:19
PageRepository.php:580Didn't you mean to use "false" here to have "1" also matched? -
Benni Mack commented on patch set 5 10/30/18, 11:21
"1" is fine, could be added separately in the TCA migrationPageRepository.php:580ReplyI rechecked with "sys_file_metadata" and it had 1 as integer, so this was important to be non-breaking, so we're OK as it is. -
Mathias Brodala commented on patch set 5 10/30/18, 11:27
PageRepository.php:580ReplyAlright, thanks for checking. -
TYPO3com voted on patch set 4 V +1 10/30/18, 11:28 Completed build in 12m 47s on Tue, 30 Oct, 12:28 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29873
-
TYPO3com voted on patch set 5 V +1 10/30/18, 11:33 Completed build in 14m 10s on Tue, 30 Oct, 12:33 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29874
-
Wouter Wolters voted on patch set 5 V +2 CR +2 10/30/18, 20:23
-
Wouter Wolters merged patch set 6 10/30/18, 20:23