Review main Merged

57418[TASK] Streamline FAL pre-emit signals for createFile and setContent

Oliver Hader CR +2 V +2 Easy +26 −0 updated 07/12/18, 09:50

Commit message

In order to streamline the FAL API the following signals have been added.
The according post-processing signals have been available already before:

+ ResourceStorageInterface::SIGNAL_PreFileCreate
+ ResourceStorageInterface::SIGNAL_PreFileSetContents

Review

  • Code review CR +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Frans Saris +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1011

  1. Oliver Hader uploaded patch set 1 06/29/18, 13:04

  2. TYPO3com voted on patch set 1 V +1 06/29/18, 13:13 Completed build in 08m 36s on Fri, 29 Jun, 03:13 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24983

  3. Susi Moog voted on patch set 1 CR +1 06/29/18, 13:14

  4. Andreas Kienast voted on patch set 1 CR +1 06/29/18, 13:22

  5. Susi Moog voted on patch set 1 V +1 06/29/18, 14:08

  6. Wouter Wolters voted on patch set 1 CR +1 06/29/18, 17:34

  7. Frans Saris voted on patch set 1 CR +1 06/30/18, 06:39

  8. Frans Saris voted on patch set 1 V +2 CR +2 06/30/18, 06:42

  9. Frans Saris merged patch set 2 06/30/18, 06:42

  10. Frans Saris commented on patch set 2 06/30/18, 06:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4a8b467b0a96410598d9781c78695b087a8ba05a
  11. Benni Mack commented on patch set 2 07/12/18, 09:50

    Cherry Picked This patchset was cherry picked to branch 9.3 as commit 792e5cb882e5ecc1e93533217d7739bbcc3259cb