Review main Merged

57422[TASK] Remove ugly empty area when container element is empty

Łukasz Uznański CR +2 V +2 Easy +13 −1 updated 08/03/18, 12:09

Commit message

Remove margin from container elements

Review

  • Code review CR +2
    • Frank Nägler +2
    • Joerg Kummer +1
    • Anja Leichsenring +1
    • Paweł Rogowicz +1
  • Verified V +2
    • Frank Nägler +2
    • Joerg Kummer +1
    • Anja Leichsenring +1
    • Riccardo De Contardi +1
    • Paweł Rogowicz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2632

Show 47 earlier messages
  1. Łukasz Uznański uploaded patch set 1 06/30/18, 14:31

  2. Łukasz Uznański uploaded patch set 2 06/30/18, 14:37

  3. TYPO3com voted on patch set 1 V +1 06/30/18, 14:40 Completed build in 08m 57s on Sat, 30 Jun, 04:40 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24986

  4. TYPO3com voted on patch set 2 V +1 06/30/18, 14:45 Completed build in 08m 16s on Sat, 30 Jun, 04:45 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24988

  5. Łukasz Uznański updated the commit message in patch set 3 06/30/18, 19:26

  6. TYPO3com voted on patch set 3 V +1 06/30/18, 19:34 Completed build in 08m 04s on Sat, 30 Jun, 09:34 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24989

  7. Łukasz Uznański uploaded patch set 4 07/02/18, 09:24

  1. Paweł Rogowicz voted on patch set 4 CR +1 07/02/18, 09:31

  2. TYPO3com voted on patch set 4 V +1 07/02/18, 09:32 Completed build in 08m 07s on Mon, 2 Jul, 11:32 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25014

  3. Riccardo De Contardi commented on patch set 4 07/06/18, 21:13

    this patch also removes the margin top between the container and its elements inside. Try to put some fields inside the grid or fleldset
  4. Łukasz Uznański uploaded patch set 5 07/08/18, 14:20

  5. Łukasz Uznański commented on patch set 5 07/08/18, 14:21

    That's true, thanks for feedback. I added margin-top to first of type nested element.
  6. TYPO3com voted on patch set 5 V +1 07/08/18, 14:27 Completed build in 07m 35s on Sun, 8 Jul, 04:27 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25227

  7. Riccardo De Contardi commented on patch set 5 07/08/18, 15:03

    seems still the same... check specificity please, my first suspect :)
  8. Łukasz Uznański commented on patch set 5 07/09/18, 08:33

    Maybe something cached in my browser, sorry. I will check this today and fix.
  9. Łukasz Uznański uploaded patch set 6 07/09/18, 18:36

  10. TYPO3com voted on patch set 6 V +1 07/09/18, 18:45 Completed build in 08m 56s on Mon, 9 Jul, 08:45 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25262

  11. Łukasz Uznański commented on patch set 6 07/10/18, 14:47

    Should be fine right now. In patch set 5 i did not include builded css.
  12. Riccardo De Contardi commented on patch set 6 V +1 07/10/18, 19:51

    seems good
  13. Paweł Rogowicz voted on patch set 6 CR -1 07/30/18, 08:09

  14. Paweł Rogowicz voted on patch set 6 CR +1 08/02/18, 09:19

  15. Paweł Rogowicz voted on patch set 6 V +1 08/02/18, 09:47

  16. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/02/18, 14:10

  17. Joerg Kummer voted on patch set 6 V +1 CR +1 08/02/18, 15:42

  18. Frank Nägler commented on patch set 6 V -1 08/02/18, 19:54

    can't verify this change. can someone explain wow to test? maybe add before and after screenshots to the issue-
  19. Riccardo De Contardi commented on patch set 6 08/02/18, 20:04

    @Frank I'm going to add a screenshot of the problem to the issue on forge
  20. Frank Nägler commented on patch set 6 08/02/18, 20:10

    thanks Ricardo, but also with this patch the space is still there. So for me, this does not fix the issue, I am really sure it is not my browser cache. can you also add a screenshot with the patch applied?
  21. Riccardo De Contardi commented on patch set 6 08/02/18, 20:36

    Strange... I am testing it on Chrome, FF and Safari on Mac and the patch works (I cleared the browser's cache)
  22. Łukasz Uznański commented on patch set 6 08/03/18, 08:45

    @Frank I added screenshot with applied patchset, you can check :)
  23. Anja Leichsenring commented on patch set 6 08/03/18, 09:23

    > Patch Set 6: > > @Frank I added screenshot with applied patchset, you can check :) you really have to reload the BE, worked for me only at the third attempt, too.
  24. Frank Nägler commented on patch set 6 V +2 CR +2 08/03/18, 12:09

    tested again, now it works, thx for the screenshots
  25. Frank Nägler merged patch set 7 08/03/18, 12:09