Review main Merged

57424[TASK] Add LanguageAspect to Contexts

Benni Mack CR +2 V +2 Expert +844 −277 updated 09/20/18, 12:29

Commit message

This change adds a new Aspect called "Language" which bundles
most existing TypoScript options on frontend language fetching.
A factory allows to migrate the logic from TSFE.

Major / Important Changes:
- RootlineUtility is decoupled from PageRepository
- TSFE->sys_language_mode is not necessary anymore
- TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect
- A new PageRepository->getLanguageOverlay() bundles all other methods
- A lot of common public properties in TSFE are now deprecated

Next steps:
- Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE
- Migrate PageRepository "-1" parameters to "null"
- Migrate usages PageRepository->getRootline() to RootlineUtility::__construct()
- Then deprecate PageRepository->getRootLine()
- Migrate Extbase QuerySettings to Contexts

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 27

Show 7 more files

Review log 3356

Show 1631 earlier messages
  1. Benni Mack uploaded patch set 1 07/01/18, 12:47

  2. TYPO3com voted on patch set 1 V -1 07/01/18, 12:55 Completed build in 07m 48s on Sun, 1 Jul, 02:55 PM Test Summary: 2396 of 33121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24990

  3. Benni Mack uploaded patch set 2 07/01/18, 13:16

  4. TYPO3com voted on patch set 2 V -1 07/01/18, 13:24 Completed build in 07m 46s on Sun, 1 Jul, 03:24 PM Test Summary: 6 of 33121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24991

  5. Benni Mack uploaded patch set 3 07/01/18, 13:35

  6. TYPO3com voted on patch set 3 V -1 07/01/18, 13:43 Completed build in 08m 10s on Sun, 1 Jul, 03:43 PM Test Summary: 3 of 33121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24992

  7. Benni Mack uploaded patch set 4 07/01/18, 14:51

  8. TYPO3com voted on patch set 4 V +1 07/01/18, 15:00 Completed build in 09m 05s on Sun, 1 Jul, 05:00 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24993

  9. Mathias Brodala commented on patch set 4 07/02/18, 07:15

    LanguageAspect.php:86

    This should be an Enumeration instead IMO. Then you also get validation for free. ;-)
  10. Benni Mack uploaded patch set 5 07/02/18, 12:19

  11. TYPO3com voted on patch set 5 V +1 07/02/18, 12:31 Completed build in 11m 45s on Mon, 2 Jul, 02:31 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25029

  12. Benni Mack uploaded patch set 6 07/12/18, 17:41

  13. TYPO3com voted on patch set 6 V -1 07/12/18, 17:47 Completed build in 06m 08s on Thu, 12 Jul, 07:47 PM Test Summary: 2309 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25336

  14. Benni Mack uploaded patch set 7 07/12/18, 17:51

  15. TYPO3com voted on patch set 7 V -1 07/12/18, 17:58 Completed build in 06m 32s on Thu, 12 Jul, 07:58 PM Test Summary: 624 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25337

  16. Benni Mack uploaded patch set 8 07/12/18, 18:22

  17. TYPO3com voted on patch set 8 V -1 07/12/18, 18:29 Completed build in 07m 14s on Thu, 12 Jul, 08:29 PM Test Summary: 615 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25339

  18. Benni Mack uploaded patch set 9 07/12/18, 19:14

  19. TYPO3com voted on patch set 9 V +1 07/12/18, 19:21 Completed build in 06m 34s on Thu, 12 Jul, 09:21 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25340

  20. Benni Mack uploaded patch set 10 07/12/18, 19:59

  21. TYPO3com voted on patch set 10 V +1 07/12/18, 20:05 Completed build in 06m 32s on Thu, 12 Jul, 10:06 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25341

  22. Benni Mack uploaded patch set 11 07/12/18, 20:18

  23. TYPO3com voted on patch set 11 V -1 07/12/18, 20:25 Completed build in 07m 04s on Thu, 12 Jul, 10:25 PM Test Summary: 117 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25342

  24. Benni Mack uploaded patch set 12 07/12/18, 20:25

  25. TYPO3com voted on patch set 12 V -1 07/12/18, 20:32 Completed build in 06m 38s on Thu, 12 Jul, 10:32 PM Test Summary: 117 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25343

  26. Benni Mack uploaded patch set 13 07/12/18, 20:54

  27. TYPO3com voted on patch set 13 V -1 07/12/18, 20:54 Completed build in 18s on Thu, 12 Jul, 10:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25346

  28. Benni Mack uploaded patch set 14 07/12/18, 21:05

  29. TYPO3com voted on patch set 14 V -1 07/12/18, 21:12 Completed build in 06m 39s on Thu, 12 Jul, 11:12 PM Test Summary: 171 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25349

  30. Benni Mack uploaded patch set 15 07/13/18, 08:22

  31. TYPO3com voted on patch set 15 V -1 07/13/18, 08:29 Completed build in 07m 18s on Fri, 13 Jul, 10:29 AM Test Summary: 171 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25352

  1. Benni Mack uploaded patch set 16 07/13/18, 12:00

  2. TYPO3com voted on patch set 16 V -1 07/13/18, 12:07 Completed build in 06m 39s on Fri, 13 Jul, 02:07 PM Test Summary: 171 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25357

  3. Benni Mack uploaded patch set 17 07/13/18, 12:58

  4. TYPO3com voted on patch set 17 V +1 07/13/18, 13:05 Completed build in 06m 38s on Fri, 13 Jul, 03:05 PM Test Summary: 33333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25361

  5. Benni Mack uploaded patch set 18 07/13/18, 14:33

  6. TYPO3com voted on patch set 18 V -1 07/13/18, 14:40 Completed build in 06m 46s on Fri, 13 Jul, 04:40 PM Test Summary: 18 of 33578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25366

  7. Benni Mack uploaded patch set 19 07/13/18, 15:37

  8. Benni Mack uploaded patch set 20 07/13/18, 15:43

  9. TYPO3com voted on patch set 19 V +1 07/13/18, 15:44 Completed build in 07m 11s on Fri, 13 Jul, 05:44 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25374

  10. TYPO3com voted on patch set 20 V -1 07/13/18, 15:51 Completed build in 08m 25s on Fri, 13 Jul, 05:51 PM Test Summary: 15 of 33581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25375

  11. Benni Mack uploaded patch set 21 07/13/18, 16:08

  12. TYPO3com voted on patch set 21 V +1 07/13/18, 16:15 Completed build in 07m 18s on Fri, 13 Jul, 06:15 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25378

  13. Benni Mack uploaded patch set 22 07/13/18, 16:19

  14. TYPO3com voted on patch set 22 V +1 07/13/18, 16:27 Completed build in 07m 33s on Fri, 13 Jul, 06:27 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25379

  15. Benni Mack uploaded patch set 23 07/13/18, 16:40

  16. TYPO3com voted on patch set 23 V +1 07/13/18, 16:47 Completed build in 07m 42s on Fri, 13 Jul, 06:47 PM Test Summary: 33336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25380

  17. Christian Kuhn voted on patch set 23 CR +1 07/13/18, 17:24

  18. Christian Kuhn voted on patch set 23 V +1 07/13/18, 17:27

  19. Andreas Kienast commented on patch set 23 CR -1 07/13/18, 18:16

    on it
  20. Andreas Kienast voted on patch set 23 V +2 CR +2 07/13/18, 18:39

  21. Andreas Kienast merged patch set 24 07/13/18, 18:39

  22. Markus Klein commented on patch set 24 09/11/18, 19:57

    AbstractMenuContentObject.php:1306

    still used here, but never defined. see https://review.typo3.org/58252
  23. Benni Mack commented on patch set 24 09/12/18, 04:21

    AbstractMenuContentObject.php:1306 Reply

    wow. thanks for the info!
  24. Mathias Brodala commented on patch set 24 09/12/18, 07:07

    LanguageAspect.php:79

    What? ;-)
  25. Tymoteusz Motylewski commented on patch set 24 09/20/18, 12:29

    Typo3QuerySettings.php:113

    why the condition is here? This means that global TS configuration like language mode or overlay is only set if we're in L>0. The thing is there are situations where you query different language then one in global context. And in this situation you will need to explicitly set these settings on the query.