Review main Merged

57431[TASK] Streamline initialization of PageRepository

Benni Mack CR +2 V +2 Normal +114 −107 updated 07/02/18, 12:10

Commit message

PageRepository ($TSFE->sys_page) has an init() function, which sets
some public properties, but is also called from the constructor.

However, there is the ominous $TSFE->setSysPageWhereClause()
which can only be set once the frontend user groups have been resolved.

In order to achieve that, the usergroup initialization within TSFE has
been moved before the intantiation of $TSFE->sys_page, allowing the
pagerepository constructor to set the variables directly, moving all
of the initialization code into PageRepository itself.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 913

  1. Benni Mack uploaded patch set 1 07/01/18, 15:24

  2. TYPO3com voted on patch set 1 V -1 07/01/18, 15:33 Completed build in 08m 47s on Sun, 1 Jul, 05:33 PM Test Summary: 2274 of 33121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24996

  3. Benni Mack uploaded patch set 2 07/01/18, 16:13

  4. TYPO3com voted on patch set 2 V -1 07/01/18, 16:20 Completed build in 07m 00s on Sun, 1 Jul, 06:20 PM Test Summary: 6 of 33121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25002

  5. Benni Mack uploaded patch set 3 07/02/18, 10:35

  6. TYPO3com voted on patch set 3 V -1 07/02/18, 10:43 Completed build in 08m 17s on Mon, 2 Jul, 12:43 PM Test Summary: 6 of 33121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25021

  7. Christian Kuhn uploaded patch set 4 07/02/18, 11:36

  8. TYPO3com voted on patch set 4 V +1 07/02/18, 11:44 Completed build in 07m 38s on Mon, 2 Jul, 01:44 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25023

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 07/02/18, 11:44

  10. Wouter Wolters voted on patch set 4 CR +1 07/02/18, 11:54

  11. Andreas Kienast voted on patch set 4 CR +1 07/02/18, 11:55

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 07/02/18, 12:10

  13. Andreas Kienast merged patch set 5 07/02/18, 12:10