Review main Merged

57434[BUGFIX] Remove unused Doctrine restriction

Benni Mack CR +2 V +2 Easy +0 −5 updated 07/02/18, 09:16

Commit message

During the Doctrine DBAL refactoring, an
additional check for $TSFE->sys_page->showHiddenRecords
was introduced.

First of all: This check is not needed
as the restriction container is checking for
the REAL value correctly by using
$TSFE->showHiddenRecords.

Additionally, it checks for an invalid
property on PHP object property, which
is never a good idea.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 07/01/18, 18:17

  2. Wouter Wolters voted on patch set 1 CR +1 07/01/18, 18:25

  3. TYPO3com voted on patch set 1 V +1 07/01/18, 18:26 Completed build in 09m 02s on Sun, 1 Jul, 08:26 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25006

  4. Andreas Kienast voted on patch set 1 CR +1 07/02/18, 06:43

  5. Christian Kuhn commented on patch set 1 V +1 CR +1 07/02/18, 09:09

    this is actually a near no-brainer since PageRepository (tsfe->sys_page) has no such property.
  6. Frank Nägler voted on patch set 1 V +1 CR +1 07/02/18, 09:15

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 07/02/18, 09:15

  8. Christian Kuhn merged patch set 2 07/02/18, 09:15

  9. Christian Kuhn commented on patch set 2 07/02/18, 09:16

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c7dab7b989d6c74302d6312a97f59e58fd270b1d