Review TYPO3_8-7 Merged

57437[BUGFIX] Remove unused Doctrine restriction

Christian Kuhn CR +2 V +2 Easy +0 −5 updated 07/02/18, 10:01

Commit message

During the Doctrine DBAL refactoring, an
additional check for $TSFE->sys_page->showHiddenRecords
was introduced.

First of all: This check is not needed
as the restriction container is checking for
the REAL value correctly by using
$TSFE->showHiddenRecords.

Additionally, it checks for an invalid
property on PHP object property, which
is never a good idea.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 07/02/18, 09:16

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 07/02/18, 09:25 Completed build in 09m 40s on Mon, 2 Jul, 11:25 AM Test Summary: 58422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2647

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 07/02/18, 10:01

  4. Christian Kuhn merged patch set 2 07/02/18, 10:01