Review main Merged

57438[TASK] Deprecate ContentObjectRenderer->calcIntExplode()

Benni Mack CR +2 V +2 Normal +64 −2 updated 07/02/18, 12:29

Commit message

The method ContentObjectRenderer->calcIntExplode() is only used
within GraphicalMenuObject and can be migrated into the method call.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1014

  1. Benni Mack uploaded patch set 1 07/02/18, 10:05

  2. TYPO3com voted on patch set 1 V +1 07/02/18, 10:14 Completed build in 09m 43s on Mon, 2 Jul, 12:14 PM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25017

  3. Christian Kuhn uploaded patch set 2 07/02/18, 11:58

  4. TYPO3com voted on patch set 2 V +1 07/02/18, 12:06 Completed build in 07m 46s on Mon, 2 Jul, 02:06 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25024

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 07/02/18, 12:07

  6. Andreas Kienast commented on patch set 2 CR -1 07/02/18, 12:13

    MethodCallMatcher.php:2427 Unresolved

    engrish?
  7. Andreas Kienast rebased onto patch set 3 07/02/18, 12:15

  8. Andreas Kienast uploaded patch set 4 07/02/18, 12:15

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 07/02/18, 12:16

  10. Christian Kuhn voted on patch set 4 V +2 CR +2 07/02/18, 12:23

  11. Benni Mack voted on patch set 4 V +2 CR +2 07/02/18, 12:24

  12. TYPO3com voted on patch set 3 V +1 07/02/18, 12:26 Completed build in 11m 08s on Mon, 2 Jul, 02:26 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25027

  13. TYPO3com voted on patch set 4 V +1 07/02/18, 12:26 Completed build in 10m 58s on Mon, 2 Jul, 02:26 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25028

  14. Christian Kuhn merged patch set 5 07/02/18, 12:29