Review TYPO3_8-7 Merged

57446[BUGFIX] Display documentation changelog files with same issue number

Christian Kuhn CR +2 V +2 Easy +13 −14 updated 07/02/18, 12:39

Commit message

By using a hash instead of the issue number as array key, no file gets
lost any longer due to collision. Same issue numbers for documentation
files are quite common, e.g. when a new feature deprecates replaced code.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn commented on patch set 1 07/02/18, 12:24

    Cherry Picked from branch master.
  2. Christian Kuhn commented on patch set 1 07/02/18, 12:28

    retested for v8: looks good.
  3. TYPO3com voted on patch set 1 V +1 07/02/18, 12:33 Completed build in 08m 58s on Mon, 2 Jul, 02:33 PM Test Summary: 58428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2652

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 07/02/18, 12:39

  5. Christian Kuhn merged patch set 2 07/02/18, 12:39