Review main Abandoned

57448[WIP][BUGFIX] Collapse panels in "View Upgrade Documentation" after emptying search

Andreas Kienast CR 0 V 0 Easy +19 −8 updated 09/20/18, 05:42

Commit message

In the Install Tool, the content of the modal must be explicitly
referenced when accessing elements. This patch ensures that all
panels are closed when the search field has been cleared to
reset the view to the original state.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 69

  1. Andreas Kienast uploaded patch set 1 07/02/18, 13:04

  2. Markus Klein commented on patch set 1 07/02/18, 13:06

    been
  3. Markus Klein updated the commit message in patch set 2 07/02/18, 13:06

  4. TYPO3com voted on patch set 1 V +1 07/02/18, 13:14 Completed build in 09m 23s on Mon, 2 Jul, 03:14 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25037

  5. TYPO3com voted on patch set 2 V +1 07/02/18, 13:16 Completed build in 09m 48s on Mon, 2 Jul, 03:16 PM Test Summary: 32880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25038

  6. Andreas Kienast commented on patch set 2 V -1 07/02/18, 14:51

    The behaviour is broken in multiple occurrences, these need to get fixed as well.
  7. Jürgen Venne uploaded patch set 3 07/06/18, 20:02

  8. TYPO3com voted on patch set 3 V +1 07/06/18, 20:10 Completed build in 08m 13s on Fri, 6 Jul, 10:10 PM Test Summary: 32883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25196

  9. Andreas Kienast abandoned the change 09/20/18, 05:42

    Will abandon for now, may be revived during v10 development.